Add set_identity tests #3794
Add set_identity tests #3794
Conversation
| expected_validator_id.pubkey().to_string() | ||
| ); | ||
|
|
||
| let contact_info_request = |
There was a problem hiding this comment.
it also tests that exit call works properly but this is not reflected in the name of the test.
| }"#, | ||
| ) | ||
| .expect("Failed to parse expected response"); | ||
| assert_eq!(actual_parsed_response, expected_parsed_response); |
There was a problem hiding this comment.
this feels a little fragile. Could we just check for null result so that we don't have to update this for benign things like a version change?
validator/src/admin_rpc_service.rs
Outdated
| let leader_keypair = Keypair::new(); | ||
| let leader_node = Node::new_localhost_with_pubkey(&leader_keypair.pubkey()); | ||
|
|
||
| let validator_keypair = Keypair::new(); | ||
| let validator_node = Node::new_localhost_with_pubkey(&validator_keypair.pubkey()); | ||
| let genesis_config = | ||
| create_genesis_config_with_leader(10_000, &leader_keypair.pubkey(), 1000) | ||
| .genesis_config; | ||
| let (validator_ledger_path, _blockhash) = create_new_tmp_ledger!(&genesis_config); | ||
|
|
||
| let voting_keypair = Arc::new(Keypair::new()); | ||
| let voting_pubkey = voting_keypair.pubkey(); | ||
| let authorized_voter_keypairs = Arc::new(RwLock::new(vec![voting_keypair])); | ||
| let validator_config = ValidatorConfig { | ||
| rpc_addrs: Some(( | ||
| validator_node.info.rpc().unwrap(), | ||
| validator_node.info.rpc_pubsub().unwrap(), | ||
| )), | ||
| ..ValidatorConfig::default_for_test() | ||
| }; | ||
| let start_progress = Arc::new(RwLock::new(ValidatorStartProgress::default())); | ||
|
|
||
| let post_init = Arc::new(RwLock::new(None)); | ||
| let meta = AdminRpcRequestMetadata { | ||
| rpc_addr: validator_config.rpc_addrs.map(|(rpc_addr, _)| rpc_addr), | ||
| start_time: SystemTime::now(), | ||
| start_progress: start_progress.clone(), | ||
| validator_exit: validator_config.validator_exit.clone(), | ||
| authorized_voter_keypairs: authorized_voter_keypairs.clone(), | ||
| tower_storage: Arc::new(NullTowerStorage {}), | ||
| post_init: post_init.clone(), | ||
| staked_nodes_overrides: Arc::new(RwLock::new(HashMap::new())), | ||
| rpc_to_plugin_manager_sender: None, | ||
| }; | ||
|
|
||
| let _validator = Validator::new( | ||
| validator_node, | ||
| Arc::new(validator_keypair), | ||
| &validator_ledger_path, | ||
| &voting_pubkey, | ||
| authorized_voter_keypairs, | ||
| vec![leader_node.info], | ||
| &validator_config, | ||
| true, // should_check_duplicate_instance | ||
| None, // rpc_to_plugin_manager_receiver | ||
| start_progress.clone(), | ||
| SocketAddrSpace::Unspecified, | ||
| DEFAULT_TPU_USE_QUIC, | ||
| DEFAULT_TPU_CONNECTION_POOL_SIZE, | ||
| DEFAULT_TPU_ENABLE_UDP, | ||
| 32, // max connections per IpAddr per minute for test | ||
| post_init, | ||
| ) | ||
| .expect("assume successful validator start"); | ||
| assert_eq!( | ||
| *start_progress.read().unwrap(), | ||
| ValidatorStartProgress::Running | ||
| ); |
There was a problem hiding this comment.
seems like we should have some test API that basically covers these setup activities and allows us to extract the RPC address
There was a problem hiding this comment.
Do you propose to extract a function for this setup?
There was a problem hiding this comment.
I'm sort of surprised that a setup abstraction doesn't already exist (or something really close to what you have).
But yes, I think pulling out the setup into a function would help with readability
There was a problem hiding this comment.
Got you. Yeah, i was also surprised. Maybe I was grepping wrong phrase but I could not find tests for this admin rpc. But I should say that there is LocalCluster helper but it doesn't work here without quite some modifications.
KirillLykov
force-pushed
the
klykov/add-set-identity-tests
branch
from
dadec3a
to
d30cc41
Compare
Problem
I haven't found tests for the
set_identitycall. I want this functionality to be covered by test because there will be a PR introducing a new network client that is subscribed to the change identity notification.Summary of Changes