svm: simplify inspect logic #3769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2501babe
force-pushed
the
20241124_inspectfix
branch
3 times, most recently
from
a37e2bd
to
8e2a228
Compare
2501babe
force-pushed
the
20241124_inspectfix
branch
from
8e2a228
to
2593d63
Compare
jstarry
previously approved these changes
Nov 27, 2024
svm/src/account_loader.rs
Outdated
| // If lamports is 0, a previous transaction deallocated this account. | ||
| // Return None without inspecting, so it can be recreated. | ||
| // We must shadow the cache entry so the account may be reopened. |
There was a problem hiding this comment.
I don't really get what this comment is trying to say
There was a problem hiding this comment.
i reworded it to be clearer, i just meant we have to ignore whats in account_cache because load_transaction_account needs to run the same logic as if there was nothing in accounts-db
jstarry
approved these changes
Nov 27, 2024
pgarg66
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
current inspect flow is not quite right, an account that has been dropped may be inspected as alive instead of dead. this is harmless, because the first inspect will necessary be as writable, but technically incorrect
Summary of Changes
fix it. originally i was going to inspect inside the lamports if/else but i realized we can simply inspect after resolving the account, so now we only have one place in svm where this function is called