-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vote: add ephemeral bankhash and slot to TowerSync #2967
base: master
Are you sure you want to change the base?
Conversation
The Firedancer team maintains a line-for-line reimplementation of the |
18f9f0d
to
ae5cbb6
Compare
ae5cbb6
to
4e1c8bb
Compare
@@ -788,7 +788,7 @@ pub mod remove_rounding_in_fee_calculation { | |||
} | |||
|
|||
pub mod enable_tower_sync_ix { | |||
solana_program::declare_id!("tSynMCspg4xFiCj1v3TDb4c7crMR5tSBhLz4sF7rrNA"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feature is rekeyed to avoid any accidental activation before this is released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
Should we collab on the SIMD first before getting too dug in on implementation details? |
4e1c8bb
to
0da8efa
Compare
I'm fine with this, I suggested this change because we're already adding a new vote ix for block_id so figured it would be easier to have 1 migration rather than 2. However it seems like we're not in a rush for block_id so happy to wait until we've agreed on the APE SIMD first. |
Sure, still working on the SIMD, but comments welcome: solana-foundation/solana-improvement-documents#165 |
0da8efa
to
8fe05e7
Compare
8fe05e7
to
33eae15
Compare
Problem
Asynchronous execution needs to track the ephemeral bank hash separately from the latest replayed bank hash. Additionally we need a slot # to now go with the bank hash. This requires a new vote ix format.
Summary of Changes
Since we are already in the midst of a vote ix upgrade for block_id, add this now to avoid having to go through another migration.