Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can router not bridge other minters tokens? #5

Open
sirpy opened this issue May 16, 2022 · 1 comment
Open

Can router not bridge other minters tokens? #5

sirpy opened this issue May 16, 2022 · 1 comment

Comments

@sirpy
Copy link

sirpy commented May 16, 2022

I'm not sure this logic is the intended one.
For example in our own use case, lets say we have another bridge that mints tokens, we would like the multichain bridge to be able to swapout these tokens even though it wasnt the original minter. this is specifically true for bridges between sidechains that use mint-burn type of bridge.

require(s.total >= amount, "minter burn amount exceeded");

jowenshaw added a commit that referenced this issue May 17, 2022
minter should do this by calling 'setComintCap'
@jowenshaw
Copy link
Contributor

because erc20 token is fungible, we can not distinguish the co-minted tokens, but we can refine this judge, make it under the minter's control.

jowenshaw added a commit that referenced this issue May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants