Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move location to package id #153

Open
LordTermor opened this issue Nov 24, 2024 · 0 comments
Open

Move location to package id #153

LordTermor opened this issue Nov 24, 2024 · 0 comments
Assignees
@LordTermor
Labels
Daemon Changes related to the backend enhancement New feature or request Refactoring Readability code changes
Milestone
post-1.0

Comments

@LordTermor
Copy link
Collaborator

Right now package location (overlay, sync or automated) is located in PackageRecord entry that is being serialized into the database.

bxt/daemon/persistence/box/record/PackageRecord.h

Line 70 in 89b27da

phmap::flat_hash_map<Core::Domain::PoolLocation, Description> descriptions;

Moving it into Id (so LMDB key will become something like branch/repository/architecture/package/location) and flatting PackageRecord structure will potentially greatly reduce code complexity/control flow related to multiple package locations persistence.
@LordTermor LordTermor added enhancement New feature or request Daemon Changes related to the backend Refactoring Readability code changes labels Nov 24, 2024
@LordTermor LordTermor self-assigned this Nov 24, 2024
@LordTermor LordTermor added this to the post-1.0 milestone Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LordTermor LordTermor

Labels
Daemon Changes related to the backend enhancement New feature or request Refactoring Readability code changes
Projects
None yet
Milestone
post-1.0
Development

No branches or pull requests
1 participant
@LordTermor