Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTree expansion freezes and crashes #159

Open
NicoN13 opened this issue Oct 15, 2024 · 6 comments
Open

DataTree expansion freezes and crashes #159

NicoN13 opened this issue Oct 15, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@NicoN13
Copy link

NicoN13 commented Oct 15, 2024

I have been working with the tabulator data tree module quite a bit and for some reason I've been hitting an unexpected issue with "Maximum call stack size exceeded".

Below is a basic link which shows the issue.

https://anvil.works/build#clone:UBDP5EG7XAYO5LGT=A3H3X6KV4MD3NTBGNU4MUEDU|null

You can expand and contract Variant 6.
You can expand and contract Variant 7.
But when you expand Variant 6 and then while Variant 6 is expanded also try and expand Variant 7, the app crashes completely.

For the life of me, I can't figure out why. It's a small amount of data. It makes me think that it's a rendering issue but the message I receive is that of Maximum call stack size exceeded.

Thanks for looking into it!

@s-cork s-cork added the bug Something isn't working label Oct 15, 2024
@s-cork
Copy link
Collaborator

s-cork commented Oct 15, 2024

This looks like a bug in tabulator core
(If i run your app without the python wrapper I get the same issue)

are you able to reduce your example to the most minimal example that produces the error
(less data and fewer columns)
then i'll turn it into a minimal example and report the issue upstream

@s-cork
Copy link
Collaborator

s-cork commented Oct 15, 2024

Note - this only seems to be an issue in 3.x so if you revert to 2.x it should work

@NicoN13
Copy link
Author

NicoN13 commented Oct 15, 2024

Sure thing, I'll reduce as far as possible and let you know. Thanks @s-cork

@NicoN13
Copy link
Author

NicoN13 commented Oct 15, 2024

Data and example reduced. You can try and expand all 3 variants, and then it crashes. Same link as provided above.

@NicoN13
Copy link
Author

NicoN13 commented Oct 17, 2024

Some additional playing around with it lead me to find that it partially has to do with the maxHeight setting. If you remove maxHeight from tabulator options, then this minimum example no longer crashes.

@s-cork
Copy link
Collaborator

s-cork commented Oct 17, 2024

good to know!
I've now created an issue upstream with a working example that crashes
see: olifolkerd/tabulator#4599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants