kompot.batch_call api

[hugetim]

Now I'm wondering whether it might be better to use results as the name of the attribute collecting the return values.

Also, it's now striking me as odd to reference the context manager object (c in the example code) outside of the with statement context. I think I've just never seen a use of a with statement like that. Does that seem fine to others?

[meatballs]

I think I've just never seen a use of a with statement like that. Does that seem fine to others?

Perfectly normal. You'll find plenty of example using files with something like:

with open("some_file", "w") as f:
    f.write("hello world")

[hugetim]

Right, but you don't usually see f referenced after the indented context, like:

with open("some_file", "w") as f:
    f.write("hello world")
assert(f.closed)

But I guess there's no problem with it.

[s-cork]

Checkout the context manager in unittest for assertRaises.

with self.assertRaises(ZeroDivisionError) as e:
  1/0
self.assertIn("zero", repr(e.exception))

So also perfectly normal.

Buyers remorse?

result/results.
It's the result of doing all the server calls. But it doesn't much bother me.

[hugetim]

I just thought the plural would help signal that it returns a list containing the results from the multiple server functions called. But no biggie.