Attribute Error on Mobile (android) scroll #324

chad63e · 2022-04-21T21:53:49Z

chad63e
Apr 21, 2022

I am getting this error when scrolling on my mobile phone:

AttributeError: 'HTMLDocument' object has no attribute 'closest' at app/anvil_extras/popover.py, line 399

s-cork · 2022-04-21T22:05:51Z

s-cork
Apr 21, 2022
Maintainer

What version is your OS on your mobile?
And which browser?

0 replies

chad63e · 2022-04-21T22:07:24Z

chad63e
Apr 21, 2022
Author

Android v 12 Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: stu ***@***.***> Sent: Thursday, April 21, 2022 5:06:02 PM To: anvilistas/anvil-extras ***@***.***> Cc: chad63e ***@***.***>; Author ***@***.***> Subject: Re: [anvilistas/anvil-extras] Attribute Error on Mobile (android) scroll (Discussion #324) What version is your OS on your mobile? — Reply to this email directly, view it on GitHub<#324 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALBUQ4MU25C5FTCLBJNKJGLVGHGMVANCNFSM5UAQPC3A>. You are receiving this because you authored the thread.Message ID: ***@***.***>

2 replies

s-cork Apr 21, 2022
Maintainer

And are you able to check what version of chrome you're using on the phone?

s-cork Apr 21, 2022
Maintainer

Or if it's a different browser. The version of that browser.

chad63e · 2022-04-21T22:11:54Z

chad63e
Apr 21, 2022
Author

I was using Brave. See attachment Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: stu ***@***.***> Sent: Thursday, April 21, 2022 5:09:45 PM To: anvilistas/anvil-extras ***@***.***> Cc: chad63e ***@***.***>; Author ***@***.***> Subject: Re: [anvilistas/anvil-extras] Attribute Error on Mobile (android) scroll (Discussion #324) Or if it's a different browser. The version of that browser. — Reply to this email directly, view it on GitHub<#324 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALBUQ4IUWHTW6DK5KNGJ6ILVGHG2TANCNFSM5UAQPC3A>. You are receiving this because you authored the thread.Message ID: ***@***.***>

1 reply

s-cork Apr 21, 2022
Maintainer

Sending attachments doesn't work from email to GitHub discussions.

Worth downloading the GitHub app or opening the discussion in a browser.

chad63e · 2022-04-21T22:30:38Z

chad63e
Apr 21, 2022
Author

Brave v 1.37.116 Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: stu ***@***.***> Sent: Thursday, April 21, 2022 5:14:11 PM To: anvilistas/anvil-extras ***@***.***> Cc: chad63e ***@***.***>; Author ***@***.***> Subject: Re: [anvilistas/anvil-extras] Attribute Error on Mobile (android) scroll (Discussion #324) Sending attachments doesn't work from email to GitHub discussions. Worth downloading the GitHub app or opening the discussion in a browser. — Reply to this email directly, view it on GitHub<#324 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALBUQ4JYQGNQ5TDRKCYGAVTVGHHLHANCNFSM5UAQPC3A>. You are receiving this because you authored the thread.Message ID: ***@***.***>

1 reply

s-cork Apr 21, 2022
Maintainer

I think I've addressed this in PR #325
Whenever the UK wakes up then it should go live ready for you to test

chad63e · 2022-04-21T22:54:55Z

chad63e
Apr 21, 2022
Author

Thanks Stu, I'll check it out in the morning. Have a good night. Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: stu ***@***.***> Sent: Thursday, April 21, 2022 5:47:12 PM To: anvilistas/anvil-extras ***@***.***> Cc: chad63e ***@***.***>; Author ***@***.***> Subject: Re: [anvilistas/anvil-extras] Attribute Error on Mobile (android) scroll (Discussion #324) I think I've addressed this in PR #325<#325> Whenever the UK wakes up then it should go live ready for you to test — Reply to this email directly, view it on GitHub<#324 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALBUQ4OQMJ44SFI5AZ73RGLVGHLHBANCNFSM5UAQPC3A>. You are receiving this because you authored the thread.Message ID: ***@***.***>

0 replies

chad63e · 2022-04-22T14:21:01Z

chad63e
Apr 22, 2022
Author

Not sure if this update has gone live yet or not, but I am still experiencing the error. Also, It is happening on my windows pc using Chrome v 100.0.4896.127 (64 bit).

I am not sure if this might have anything to do with it, but the element that I am attaching the popover is a "circle" element within an "svg".

I have even tried adding an event listener on the parent page to trigger the popover to manually "hide" on scroll. This manual trigger does cause the popover to dismiss, but the error persists.

10 replies

s-cork Apr 22, 2022
Maintainer

ok - just double check you're on the development branch and refresh the cache
I'll need a clone please
or a link to the live app

s-cork Apr 22, 2022
Maintainer

Changes will only be on the Development version

s-cork Apr 22, 2022
Maintainer

Did you check to development version earlier? or only just now

chad63e Apr 22, 2022
Author

Now, It is giving me some odd behavior where if I have scrolled and it "toggles" the popover, the next time I click on the icon to get a new popover, it is not in the proper placement? See attached

.

I've published the app at the present development for this issue.

s-cork Apr 22, 2022
Maintainer

sorry - I don't really have enough information to help with that one.
There's an update method you can call
pop(dom_node, "update")

chad63e · 2022-04-22T16:29:13Z

chad63e
Apr 22, 2022
Author

Ok, i'll give a try Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: stu ***@***.***> Sent: Friday, April 22, 2022 11:27:35 AM To: anvilistas/anvil-extras ***@***.***> Cc: chad63e ***@***.***>; Author ***@***.***> Subject: Re: [anvilistas/anvil-extras] Attribute Error on Mobile (android) scroll (Discussion #324) sorry - I don't really have enough information to help with that one. There's an update method you can call pop(dom_node, "update") — Reply to this email directly, view it on GitHub<#324 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALBUQ4N2QE772QZOLCJZKLLVGLHPPANCNFSM5UAQPC3A>. You are receiving this because you authored the thread.Message ID: ***@***.***>

2 replies

chad63e Apr 22, 2022
Author

After some further digging, it appears that "update" and has_popover do not work with dom nodes. I was able to resolve the incorrect popover location by linking it to an Anvil component and not a dom node. Also, has_popover throws an error. I was able to reproduce the has_popover functionality with this code:

popover_id = my_dom_node.getAttribute("popover_id") or ""
has_popover = True if len(popover_id) > 0 else False

s-cork Apr 22, 2022
Maintainer

Also, has_popover throws an error.

More context please. Is this only with a dom node? Or always or sometimes or when?

chad63e · 2022-04-22T22:04:41Z

chad63e
Apr 22, 2022
Author

I believe only with dom nodes Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: stu ***@***.***> Sent: Friday, April 22, 2022 4:59:56 PM To: anvilistas/anvil-extras ***@***.***> Cc: chad63e ***@***.***>; Author ***@***.***> Subject: Re: [anvilistas/anvil-extras] Attribute Error on Mobile (android) scroll (Discussion #324) Also, has_popover throws an error. More context please. Is this only with a dom node? Or always or sometimes or when? — Reply to this email directly, view it on GitHub<#324 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALBUQ4ODDNQA6HULYUJNWITVGMONZANCNFSM5UAQPC3A>. You are receiving this because you authored the thread.Message ID: ***@***.***>

1 reply

s-cork Apr 22, 2022
Maintainer

I think given that the code now works and although I said it should work accidentally with domnodes.

I guess it doesn't.
So you're current approach is the right one.

Unless you're hindered by the current approach I don't indent to officially support domnodes.

chad63e · 2022-04-22T23:00:39Z

chad63e
Apr 22, 2022
Author

I think my current work around will work for now. Hopefully down the road this will be supported or some way to make a dom node an anvil component. Thanks for all the help! Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: stu ***@***.***> Sent: Friday, April 22, 2022 5:07:13 PM To: anvilistas/anvil-extras ***@***.***> Cc: chad63e ***@***.***>; Author ***@***.***> Subject: Re: [anvilistas/anvil-extras] Attribute Error on Mobile (android) scroll (Discussion #324) I think given that the code now works and although I said it should work accidentally with domnodes. I guess it doesn't. So you're current approach is the right one. Unless you're hindered by the current approach I don't indent to officially support domnodes. — Reply to this email directly, view it on GitHub<#324 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALBUQ4OYFLU3HTHU6IQCLWLVGMPJDANCNFSM5UAQPC3A>. You are receiving this because you authored the thread.Message ID: ***@***.***>

0 replies

lewysigns · 2022-06-09T19:24:58Z

lewysigns
Jun 9, 2022

This error is popping up for me on chrome in the IDE and Production. It only pops up when scrolling, if the pop over is shown.

The application:

 self.content_panel.popover(content="User needs to be assigned", trigger="hover", placement="top")

3 replies

s-cork Jun 9, 2022
Maintainer

@lewysigns - Are you on development or published?

Please check the dev dependency.
If it's still broken could you provide a clone link and reproduction steps.

lewysigns Jun 9, 2022

I was on published.

development does fix it. Thank you!

lewysigns Jun 9, 2022

Should Have searched #324 in the issues! sorry, still learning Github infrastructure.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Attribute Error on Mobile (android) scroll #324

{{title}}

Replies: 10 comments 20 replies

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Attribute Error on Mobile (android) scroll #324

chad63e Apr 21, 2022

Replies: 10 comments · 20 replies

s-cork Apr 21, 2022 Maintainer

chad63e Apr 21, 2022 Author

s-cork Apr 21, 2022 Maintainer

s-cork Apr 21, 2022 Maintainer

chad63e Apr 21, 2022 Author

s-cork Apr 21, 2022 Maintainer

chad63e Apr 21, 2022 Author

s-cork Apr 21, 2022 Maintainer

chad63e Apr 21, 2022 Author

chad63e Apr 22, 2022 Author

s-cork Apr 22, 2022 Maintainer

s-cork Apr 22, 2022 Maintainer

s-cork Apr 22, 2022 Maintainer

chad63e Apr 22, 2022 Author

s-cork Apr 22, 2022 Maintainer

chad63e Apr 22, 2022 Author

chad63e Apr 22, 2022 Author

s-cork Apr 22, 2022 Maintainer

chad63e Apr 22, 2022 Author

s-cork Apr 22, 2022 Maintainer

chad63e Apr 22, 2022 Author

lewysigns Jun 9, 2022

s-cork Jun 9, 2022 Maintainer

lewysigns Jun 9, 2022

lewysigns Jun 9, 2022

chad63e
Apr 21, 2022

Replies: 10 comments 20 replies

s-cork
Apr 21, 2022
Maintainer

chad63e
Apr 21, 2022
Author

s-cork Apr 21, 2022
Maintainer

s-cork Apr 21, 2022
Maintainer

chad63e
Apr 21, 2022
Author

s-cork Apr 21, 2022
Maintainer

chad63e
Apr 21, 2022
Author

s-cork Apr 21, 2022
Maintainer

chad63e
Apr 21, 2022
Author

chad63e
Apr 22, 2022
Author

s-cork Apr 22, 2022
Maintainer

s-cork Apr 22, 2022
Maintainer

s-cork Apr 22, 2022
Maintainer

chad63e Apr 22, 2022
Author

s-cork Apr 22, 2022
Maintainer

chad63e
Apr 22, 2022
Author

chad63e Apr 22, 2022
Author

s-cork Apr 22, 2022
Maintainer

chad63e
Apr 22, 2022
Author

s-cork Apr 22, 2022
Maintainer

chad63e
Apr 22, 2022
Author

lewysigns
Jun 9, 2022

s-cork Jun 9, 2022
Maintainer