Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useSchema should export a "disconnect" function to programmatically disconnect two linked nodes #31

Open
Lindsay89 opened this issue Oct 19, 2020 · 4 comments · May be fixed by #70
Open

useSchema should export a "disconnect" function to programmatically disconnect two linked nodes #31

Lindsay89 opened this issue Oct 19, 2020 · 4 comments · May be fixed by #70
Labels
enhancement New feature or request feature request Request for a new feature good first issue Good for newcomers
Milestone
0.6.0

Comments

@Lindsay89
Copy link
Contributor

Lindsay89 commented Oct 19, 2020 •
edited by antonioru
Loading

Given that useSchema currently exports a connect function to connects two different nodes and a removeNode function to remove a given node, it should also export a disconnect function to programmatically disconnect two linked nodes without removing them.
At the moment the only way to do so, is to change the schema directly.
@antonioru antonioru changed the title Disconnect function useSchema should export a "disconnect" function to programmatically disconnect two linked nodes Nov 13, 2020
@antonioru antonioru added enhancement New feature or request feature request Request for a new feature good first issue Good for newcomers labels Nov 13, 2020
ginoemiliozzi added a commit to ginoemiliozzi/beautiful-react-diagrams that referenced this issue Nov 25, 2020
@ginoemiliozzi
Add disconnect function to useSchema - antonioru#31
7060ee7
@ginoemiliozzi ginoemiliozzi mentioned this issue Nov 25, 2020
Merged
@ginoemiliozzi
Copy link

ginoemiliozzi commented Nov 25, 2020 •
edited
Loading

Hello! I've raised this PR to address this.
Please let me know if it looks fine to you :)

ginoemiliozzi added a commit to ginoemiliozzi/beautiful-react-diagrams that referenced this issue Nov 25, 2020
@ginoemiliozzi
Add disconnect function to useSchema - antonioru#31
c2f73a6
antonioru added a commit that referenced this issue Nov 26, 2020
@antonioru
Merge pull request #77 from ginoemiliozzi/disconnect-useSchema
bf8d282 
Add disconnect function exported in useSchema hook - #31
@antonioru
Copy link
Owner

Thank you @ginoemiliozzi !!!

@antonioru antonioru linked a pull request Nov 26, 2020 that will close this issue
WIP: 0.6.0 #70
Open
@antonioru antonioru reopened this Nov 26, 2020
@antonioru
Copy link
Owner

This will be solved when the #70 will be released

@antonioru antonioru added this to the 0.6.0 milestone Nov 29, 2020
Lindsay89 pushed a commit to Lindsay89/beautiful-react-diagrams that referenced this issue Dec 14, 2020
@ginoemiliozzi @Lindsay89
Add disconnect function to useSchema - antonioru#31
bb8c1e5
@importamt
Copy link

useSchema.ts needs to disconnect too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature request Request for a new feature good first issue Good for newcomers
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

WIP: 0.6.0 antonioru/beautiful-react-diagrams
4 participants
@antonioru @ginoemiliozzi @importamt @Lindsay89