Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight survey link yellow in modal #173

Open
brett-halperin opened this issue Nov 30, 2020 · 9 comments
Open

Highlight survey link yellow in modal #173

brett-halperin opened this issue Nov 30, 2020 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brett-halperin
Copy link
Collaborator

highlight yellow

Can we highlight "survey here" in yellow (color code: #FEFF54) in the modal (see image for example)

@benjaminben @timhitchins @isthewhiz
@brett-halperin brett-halperin added enhancement New feature or request good first issue Good for newcomers labels Nov 30, 2020
@isthewhiz
Copy link
Contributor

How would I pull this issue down ?
In my command line I wrote:
git checkout master
git pull upstream/master
git fetch upstream pull/173/head:pr173
no luck

isthewhiz added a commit that referenced this issue Dec 4, 2020
@isthewhiz
High-light-link addresses issue #173 (#174)
6ea0232 
* added a new class called htl to highlight link in warning ph

* added highlight color to one link

* added htl-yellow class, also added yellow color varable and added extra single quote in target.

* added htl-yellow class, also added yellow color varable and added extra single quote in target.
@erinmcel
Copy link
Contributor

erinmcel commented Dec 5, 2020

We actually don't need this survey link at all anymore as now the landlord retaliation question has been inserted into the Housing Justice Action survey that is accessible on the main map page.

@erinmcel
Copy link
Contributor

erinmcel commented Dec 5, 2020

See issue #172 in terms of renaming the survey in the map to reflect that we're now collecting LL retaliation info there

@timhitchins
Copy link
Collaborator

timhitchins commented Dec 6, 2020 via email

@isthewhiz
Copy link
Contributor

isthewhiz commented Dec 6, 2020 via email

@isthewhiz
Copy link
Contributor

isthewhiz commented Dec 6, 2020 via email

@brett-halperin
Copy link
Collaborator Author

I was thinking we could just leave it as is shown in the pic uploaded here, but swap the link to this one: https://airtable.com/shrI5HxbTqEFbk89Y - I realize that'd make it redundant, but the idea was to make it more prominent (once Maya was able to confirm which survey link was the right one). Maybe we could clear this up at the group meeting tomorrow before pushing it. Sorry for all the back and forth... I appreciate you all working on it.

@erinmcel
Copy link
Contributor

erinmcel commented Dec 7, 2020 via email

@djbusstop
Copy link
Collaborator

So far we have added highlighting

To close this issue, we should:

  • Highlight entire sentence about the survey.
  • Change the link on the survey to the correct link -> https://airtable.com/shrI5HxbTqEFbk89Y
  • Change text to -> "If you are experiencing evictions or landlord harassment, or want to share your story, you can also fill out our survey here. "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@erinmcel @timhitchins @brett-halperin @djbusstop @isthewhiz