Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: active support for Python 3.13 #3605

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

chore: active support for Python 3.13 #3605

wants to merge 11 commits into from

Conversation

clatapie
Copy link
Contributor

@clatapie clatapie commented Dec 9, 2024 •
edited
Loading

Description

Active support for Python 3.13
Closes #3600

Checklist

@clatapie clatapie self-assigned this Dec 9, 2024
@clatapie clatapie requested a review from a team as a code owner December 9, 2024 10:16
@clatapie clatapie requested review from germa89 and pyansys-ci-bot and removed request for a team December 9, 2024 10:16
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc documentation Documentation related (improving, adding, etc) dependencies maintenance General maintenance of the repo (libraries, cicd, etc) enhancement Improve any current implemented feature labels Dec 9, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (6853571) to head (f21c997).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    ansys/pymapdl#3605      +/-   ##
==========================================
- Coverage   87.02%   86.97%   -0.05%     
==========================================
  Files         187      187              
  Lines       14623    14623              
==========================================
- Hits        12725    12719       -6     
- Misses       1898     1904       +6

@clatapie clatapie requested a review from RobPasMue December 9, 2024 15:30
RobPasMue
RobPasMue reviewed Dec 9, 2024
View reviewed changes
.github/workflows/ci.yml Show resolved Hide resolved
tox.ini Show resolved Hide resolved
germa89
germa89 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when @RobPasMue suggestions have beem implemented.

@RobPasMue
Copy link
Member

@clatapie

image

Only VTK 9.4.0 is compatible with 3.13

@clatapie
Copy link
Contributor Author

Thanks @RobPasMue. I updated all the vtk versions, including the ones within .devcontainer.

@RobPasMue
Copy link
Member

Seems to me like you are hitting some PyVista 3.13 incompatibilities.

@germa89
Copy link
Collaborator

germa89 commented Dec 11, 2024

Seems to me like you are hitting some PyVista 3.13 incompatibilities.

Yep. This is on hold until ansys/ansys-tools-visualization-interface#208 is fixed.

@germa89 germa89 added the DO NOT MERGE Not ready to be merged yet label Dec 11, 2024
@germa89 germa89 marked this pull request as draft December 11, 2024 10:36
@germa89
Copy link
Collaborator

germa89 commented Dec 11, 2024

We are going to need a patch release in ATVI (ansys-tools-visualization-interface).

@RobPasMue
Copy link
Member

ATVI

Not another acronym pls 😭

@germa89
Copy link
Collaborator

germa89 commented Dec 13, 2024

ATVI

Not another acronym pls 😭

We need it! xDDD

@germa89
Copy link
Collaborator

germa89 commented Dec 13, 2024

By the way, getting Python segfaults when using VTK 9.4.0... so this PR has to wait...

#3615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue left review comments

@germa89 germa89 germa89 approved these changes

@pyansys-ci-bot pyansys-ci-bot Awaiting requested review from pyansys-ci-bot pyansys-ci-bot is a code owner automatically assigned from ansys/pymapdl-maintainers

Assignees

@clatapie clatapie

Labels
CI/CD Related with CICD, Github Actions, etc dependencies DO NOT MERGE Not ready to be merged yet documentation Documentation related (improving, adding, etc) enhancement Improve any current implemented feature maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MAINTENANCE] Support for Python 3.13
4 participants
@clatapie @RobPasMue @germa89 @pyansys-ci-bot