Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerabiliy action fails to exclude checks on lines using nosec #3609

Open
germa89 opened this issue Dec 10, 2024 · 2 comments
Open

Vulnerabiliy action fails to exclude checks on lines using nosec #3609

germa89 opened this issue Dec 10, 2024 · 2 comments
Assignees

Comments

@germa89
Copy link
Collaborator

germa89 commented Dec 10, 2024

As seen in here:

https://github.com/ansys/pymapdl/actions/runs/12258663940/job/34199044572?pr=3608#step:2:2560

However, the nosec comments should avoid triggering this warning:

return subprocess.Popen(
args=cmd,
shell=shell, # sbatch does not work without shell.
cwd=cwd,
stdin=stdin,
stdout=stdout,
stderr=stderr,
env=env_vars,
) # nosec B603 B607

@germa89
Copy link
Collaborator Author

germa89 commented Dec 10, 2024

Assigning this to @clatapie since she implemented the vulnerability check.

@germa89
Copy link
Collaborator Author

germa89 commented Dec 10, 2024

@clatapie feel free to transfer this to ansys/actions repo if you think this is a bug.

@germa89 germa89 changed the title Vulnerabiliy action fails Vulnerabiliy action fails to exclude checks on lines using nosec Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants