From bbb0931f0670478859c69ced70ecfda650674f11 Mon Sep 17 00:00:00 2001 From: gkorompi Date: Wed, 24 Apr 2024 09:17:50 +0300 Subject: [PATCH 1/3] FIX: do_pingroup --- src/pyedb/dotnet/edb_core/components.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/pyedb/dotnet/edb_core/components.py b/src/pyedb/dotnet/edb_core/components.py index f5e9bde2eb..79754173cc 100644 --- a/src/pyedb/dotnet/edb_core/components.py +++ b/src/pyedb/dotnet/edb_core/components.py @@ -785,6 +785,9 @@ def create_port_on_pins(self, refdes, pins, reference_pins, impedance=50.0, port reference_pins = [reference_pins] if isinstance(refdes, str) or isinstance(refdes, EDBComponent): refdes = self.instances[refdes] + if refdes.rlc_values: + self._logger.error("Ports cannot be assigned on RLC components") + return False if len([pin for pin in pins if isinstance(pin, str)]) == len(pins): cmp_pins = [] for pin_name in pins: From 4cd660c27b372e41ccfb0f84d637d81c35fb2318 Mon Sep 17 00:00:00 2001 From: gkorompi Date: Wed, 24 Apr 2024 10:29:49 +0300 Subject: [PATCH 2/3] FIX: ports in rlc error --- src/pyedb/dotnet/edb_core/components.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/pyedb/dotnet/edb_core/components.py b/src/pyedb/dotnet/edb_core/components.py index 79754173cc..9068995bae 100644 --- a/src/pyedb/dotnet/edb_core/components.py +++ b/src/pyedb/dotnet/edb_core/components.py @@ -785,9 +785,10 @@ def create_port_on_pins(self, refdes, pins, reference_pins, impedance=50.0, port reference_pins = [reference_pins] if isinstance(refdes, str) or isinstance(refdes, EDBComponent): refdes = self.instances[refdes] - if refdes.rlc_values: - self._logger.error("Ports cannot be assigned on RLC components") - return False + for i in refdes.rlc_values: + if i: + self._logger.error("Ports cannot be assigned on RLC components") + return False if len([pin for pin in pins if isinstance(pin, str)]) == len(pins): cmp_pins = [] for pin_name in pins: From e9c82c963a2f38412174722c32b0228439e94723 Mon Sep 17 00:00:00 2001 From: gkorompi <156683163+gkorompi@users.noreply.github.com> Date: Mon, 20 May 2024 11:48:23 +0300 Subject: [PATCH 3/3] Update src/pyedb/dotnet/edb_core/components.py MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com> --- src/pyedb/dotnet/edb_core/components.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/pyedb/dotnet/edb_core/components.py b/src/pyedb/dotnet/edb_core/components.py index 9068995bae..20d6db4771 100644 --- a/src/pyedb/dotnet/edb_core/components.py +++ b/src/pyedb/dotnet/edb_core/components.py @@ -785,10 +785,9 @@ def create_port_on_pins(self, refdes, pins, reference_pins, impedance=50.0, port reference_pins = [reference_pins] if isinstance(refdes, str) or isinstance(refdes, EDBComponent): refdes = self.instances[refdes] - for i in refdes.rlc_values: - if i: - self._logger.error("Ports cannot be assigned on RLC components") - return False + if any(refdes.rlc_values): + self._logger.error("Ports cannot be assigned on RLC components") + return False if len([pin for pin in pins if isinstance(pin, str)]) == len(pins): cmp_pins = [] for pin_name in pins: