Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PadstackData.get_pad_parameters() throw error when definition is not defined #442

Open
svandenb-dev opened this issue Oct 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@svandenb-dev
Copy link
Collaborator

📝 Description of the feature

For instance when we try to get antipad parameters but it's not defined the API throws an error, but we can't test before. We have to handle exception the API crashes. We could have a boolean, or zero values returned.
This seems to be done on purpose, but having no antipads defined is hapenning very often.

AS you can see I manage the PyEDB logger but comes also pyedb-core log

PyEDB INFO: No antipad defined for padstack definition v70h30m0mx0-layerInner1(GND1)
PyEDB INFO: No antipad defined for padstack definition v70h30m0mx0-layerInner2(PWR1)
PyEDB INFO: No antipad defined for padstack definition v70h30m0mx0-layerInner3(Sig1)
PyEDB INFO: No antipad defined for padstack definition v70h30m0mx0-layerInner4(Sig2)
PyEDB INFO: No antipad defined for padstack definition v70h30m0mx0-layerInner5(PWR2)
PyEDB INFO: No antipad defined for padstack definition v70h30m0mx0-layerInner6(GND2)
PyEDB INFO: No antipad defined for padstack definition v70h30m0mx0-layer16_Bottom
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')
ERROR - InvalidArgumentException('Get Pad Parameters was not successful, geometry shape is not set correctly.')

💡 Steps for implementing the feature

cloned_padstack_data = GrpcPadstackDefData(padstack.data.msg)
layers_name = cloned_padstack_data.layer_names
for layer in layers_name:
try:
geom_type, points, offset_x, offset_y, rotation = cloned_padstack_data.get_pad_parameters(layer,
GrpcPadType.ANTI_PAD)

🔗 Useful links and references

No response

@svandenb-dev svandenb-dev added the enhancement New feature or request label Oct 13, 2024
@svandenb-dev svandenb-dev changed the title PadstackData.get_pad_parameters() thow error when definition is not defined PadstackData.get_pad_parameters() throw error when definition is not defined Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant