Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure of "Deploy stable docs index" job #1234

Closed
3 tasks done
PProfizi opened this issue Oct 19, 2023 · 13 comments · Fixed by #1304
Closed
3 tasks done

Failure of "Deploy stable docs index" job #1234

PProfizi opened this issue Oct 19, 2023 · 13 comments · Fixed by #1304
Assignees
Labels
bug Something isn't working CI/CD Related to CI/CD

Comments

@PProfizi
Copy link
Contributor

Before submitting the issue

  • I have checked for Compatibility issues
  • I have searched among the existing issues
  • I am using a Python virtual environment

Description of the bug

Hi @Revathyvenugopal162, do you have an idea of what might have gone wrong?
Failure of the Deploy stable docs index job in releaser.yml during the latest release.

Steps To Reproduce

https://github.com/ansys/pydpf-core/actions/runs/6579035067/job/17874194117

Which Operating System causes the issue?

Windows

Which DPF/Ansys version are you using?

Ansys 2024 R1

Which Python version causes the issue?

3.10

Installed packages

NA

@PProfizi
Copy link
Contributor Author

@jorgepiloto

@germa89
Copy link
Contributor

germa89 commented Oct 30, 2023

It seems like a permission problem:

You could try to add sudo to the pip install -e ., in a proper branch, and then rerun your workflow with your action pointing to that branch.

It seems to me this action never ran completely (never use release with pymeilisearch) so it is difficult to know if something changed or something never was working.

Also, I would always put the publish to PyPI step the last one.

Pinging @RobPasMue @Revathyvenugopal162

@PProfizi
Copy link
Contributor Author

Linking the PR where pymeilisearch was added https://github.com/ansys/pydpf-core/pull/1179/files

@RobPasMue
Copy link
Member

I think this is related to the old token being re-deployed - @Revathyvenugopal162

Short term solution @PProfizi - retrigger the doc generation for the released docs. Redeploy them. And execute the meilisearch index generation for stable docs.

Is this only happening on stable docs? or also on dev docs?

@PProfizi
Copy link
Contributor Author

PProfizi commented Nov 23, 2023

Thx @RobPasMue, it does happen also on the dev doc

@PProfizi
Copy link
Contributor Author

@RobPasMue I can trigger the stable doc release again but I need to know if we must change something to the action first. We can test that by making a PR and updating the dev doc first.

@Revathyvenugopal162
Copy link
Contributor

I think this is related to the old token being re-deployed - @Revathyvenugopal162

Short term solution @PProfizi - retrigger the doc generation for the released docs. Redeploy them. And execute the meilisearch index generation for stable docs.

Is this only happening on stable docs? or also on dev docs?

yes, this is true, the is not showing any value. i dont see other issues in the PR which pymeilisearch implemented. @PProfizi the issue here was https://github.com/ansys/pydpf-core/actions/runs/6579035067/job/17874194117 the pip install . was not working to get the version. if that got fixed, the deployment will not have any issues i hope

@PProfizi
Copy link
Contributor Author

I think this is related to the old token being re-deployed - @Revathyvenugopal162
Short term solution @PProfizi - retrigger the doc generation for the released docs. Redeploy them. And execute the meilisearch index generation for stable docs.
Is this only happening on stable docs? or also on dev docs?

yes, this is true, the is not showing any value. i dont see other issues in the PR which pymeilisearch implemented. @PProfizi the issue here was https://github.com/ansys/pydpf-core/actions/runs/6579035067/job/17874194117 the pip install . was not working to get the version. if that got fixed, the deployment will not have any issues i hope

Ok, thx @Revathyvenugopal162 ! I'll try and fix that, then

@PProfizi
Copy link
Contributor Author

@Revathyvenugopal162 I might need help understanding why the dev doc index deployment failed last time with many errors, despite the job being eventually green https://github.com/ansys/pydpf-core/actions/runs/6864191191/job/18666818212#step:2:6626
Is this normal?

@PProfizi
Copy link
Contributor Author

Hi @Revathyvenugopal162 @RobPasMue I am trying to fix the deployment of the dev doc search index first but I do not understand why the search engine of the current dev doc is still not working despite this job having run:
https://github.com/ansys/pydpf-core/actions/runs/7019410820/job/19097909089#step:2:7466

@Revathyvenugopal162
Copy link
Contributor

@PProfizi , the dumbing is correct and i can see the docs already deployed on the backend, so the indexing is correct. In dev docs, it is not showing the API key in raw HTML,
image
Can you please confirm, "api_key": os.getenv("MEILISEARCH_PUBLIC_API_KEY", ""), in the conf file.if not adding this will solve the issue

@PProfizi
Copy link
Contributor Author

PProfizi commented Nov 30, 2023

Just merged a potential fix for the dev doc index deployment failure #1302
Edit: it solved the issue for the dev doc. Now there is still the problem of the stable doc index deployment job failing.

@PProfizi PProfizi linked a pull request Nov 30, 2023 that will close this issue
@PProfizi
Copy link
Contributor Author

Just merged a fix: had to use a venv to install the package, otherwise there were errors most likely due to the runner config and conflicts with pyproject.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD Related to CI/CD
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants