Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrise service name #40

Open
siamaksade opened this issue Mar 16, 2018 · 4 comments
Open

Parametrise service name #40

siamaksade opened this issue Mar 16, 2018 · 4 comments

Comments

@siamaksade
Copy link

The service name for postgresql is hard-coded to postgresql:
https://github.com/ansibleplaybookbundle/postgresql-apb/blob/master/roles/rhscl-postgresql-apb/tasks/main.yml#L28

It should be paramterized so that use can choose the service name during instantiation

@djzager
Copy link
Contributor

djzager commented Mar 16, 2018

This is related to https://bugzilla.redhat.com/show_bug.cgi?id=1542235.

@djzager
Copy link
Contributor

djzager commented Mar 20, 2018

This is a good issue @siamaksade and an excellent suggestion. When I was working on updating our hello-world-apb , I had originally made the names unique by using the _apb_service_instance_id. This gave the benefit of allowing multiple instances of the ServiceClass to be created in the same namespace without creating a new parameter...however I think that your suggestion is a better approach for solving this problem.

@djzager
Copy link
Contributor

djzager commented Mar 27, 2018

ansibleplaybookbundle/hello-world-apb#3 has been merged and uses the _apb_service_instance_id a similar change will need to be made to postgresql-apb.

@jwmatthews
Copy link

jwmatthews commented Apr 19, 2018

We plan to address this issue with all database APBs in next sprint, should have this resolved ~middle of May.

Related trello card
https://trello.com/c/5vybIGku

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants