add eda modules to the collection #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzwei
reviewed
Oct 9, 2023
…e required params so that state:absent could run without having them
|
LGTM. @jainnikhil30 Please fix the length violations. Is it possible to add tests for the modules? |
|
@jainnikhil30 please resubmit the PR to branch api-module. We're not ready to merge it to main yet. Thanks. |
|
@bzwei Okay, does that mean the modules wont be part of the actual collection release ? If yes, then how would users use the modules ? |
|
Closed this in favor of #178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 5 modules to the eda collection: