Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip check after final install #416

Open
nitzmahone opened this issue Sep 27, 2022 · 1 comment
Open

Add pip check after final install #416

nitzmahone opened this issue Sep 27, 2022 · 1 comment

Comments

@nitzmahone
Copy link
Member

nitzmahone commented Sep 27, 2022

The pip depsolver currently only issues warnings when an incompatible version of a package is installed (eg, when a later install with a conflicting dep breaks a previous one)- someone looking carefully at their container build output might see the warning text that an incompatible dep was installed, but there's no way to make that an error today.

Adding a pip check at the end of the build (available in some form since ~pip 9) will, for more modern versions of pip, re-do the dep check for all installed packages and issue an error listing the broken deps (which would fail the build). We'll probably also need EE definition syntax to disable/ignore the results of this check, but surfacing the problem by default is probably the right thing to do. Suspect we'll find a lot more busted collection deps this way, for better or worse.

@github-actions github-actions bot added the needs_triage New item that needs to be triaged label Sep 27, 2022
@eqrx eqrx removed the needs_triage New item that needs to be triaged label Oct 4, 2022
@ssbarnea
Copy link
Member

That is a very good idea, I being adding pip check even inside our tox commands for catching problems for year and it did help. One of the most useful one-linters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants