-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private python requirements impossible to install due to outdated requirements-parser #319
Comments
Hey @SirUli, sorry for the delay on this issue and thank you for the detective work. I have decided to test how dropping the dependency and would like to see if my solution fully covers you use case. Could you provide me a more complete reproducer? Don't worry if not I would use my local scenario but I want to be sure I do not miss anything :) Cheers |
madpah/requirements-parser#62 adds the required functionality to requirements-parser. It solves the problem in my setup. @SirUli can you confirm please? |
@eqrx sorry for my delayed reply. Yes now all is wonderful, this fixed the outstanding issue! Now it works, lovely :) |
@eqrx reopening - the issue is that they actually had not added the functionality but just are skipping everything that isn't "supported" and left https://github.com/madpah/requirements-parser/blob/master/requirements/parser.py#L76 which means that private repos stay unsupported. So the change that happened is actually that the private repos are skipped with a Warning and everything still continues - which is a change but actually doesn't fulfill the original issue ;) For the reproducer: Basically just add the lines from the top to any of your requirements.txt and check then during the build the requirements.txt that is generated (which actually misses the lines then). |
Oh wow, that makes my reproducer look a bit sad :D Thank you for looking into it! |
@SirUli Lets wait for discussion in madpah/requirements-parser#64 and see how we can tackle this problem. Does this work for you? |
Absolutely fine - currently this keeps us from adopting ansible-builder but we live also with the current situation. So no worries - this is a bit more tricky than I thought... |
When trying to install private python requirements the outdated library requirements-parser is in the way (Probably since it had not been
Our requirements.txt contain a couple lines in the beginning which are allowed for pip:
Both of the open PRs on that repo would fix parts of the required settings.
A couple Links on that:
Not sure which path to go but that is currently pretty much stopping us from using ansible-builder.
The text was updated successfully, but these errors were encountered: