Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix load_constraints_if_exists() filename parameter type #548

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Fix load_constraints_if_exists() filename parameter type #548

merged 1 commit into from
Feb 10, 2024

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein mentioned this pull request Sep 27, 2023
Merged
@gotmax23
Copy link
Contributor

gotmax23 commented Oct 5, 2023

It'd be better to just change the type in the antsibull_core function. The os.fspath suggestion was more of a stopgap.

@felixfontein
Copy link
Collaborator Author

Good point. I started working on that in ansible-community/antsibull-core#105.

@felixfontein @gotmax23
Improve interface.
1158170 
Co-authored-by: Maxwell G <[email protected]>
@felixfontein
Copy link
Collaborator Author

Now that we updated antsibull-core, I've updated this PR :)

gotmax23
gotmax23 approved these changes Feb 10, 2024
View reviewed changes
Copy link
Contributor

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gotmax23
Copy link
Contributor

Triggering CI

@gotmax23 gotmax23 closed this Feb 10, 2024
@gotmax23 gotmax23 reopened this Feb 10, 2024
@gotmax23 gotmax23 merged commit 50a9f4a into ansible-community:main Feb 10, 2024
18 checks passed
@felixfontein felixfontein deleted the path branch February 10, 2024 09:24
@felixfontein
Copy link
Collaborator Author

Thanks @gotmax23!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotmax23 gotmax23 gotmax23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixfontein @gotmax23