Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation viewer #91

Merged
merged 23 commits into from
May 31, 2023
Merged

Conversation

jonaprieto
Copy link
Collaborator

@jonaprieto jonaprieto commented May 30, 2023

NB: the links inside the viewer don't work and that's expected. See

test-1685467630878.mp4

@jonaprieto jonaprieto linked an issue May 30, 2023 that may be closed by this pull request
@jonaprieto jonaprieto force-pushed the 73-documentation-button-is-now-broken branch from ffa1836 to 1797025 Compare May 30, 2023 16:19
@jonaprieto jonaprieto marked this pull request as ready for review May 30, 2023 17:41
@jonaprieto jonaprieto changed the title 73 documentation button is now broken Fix documentation viewer May 30, 2023
@jonaprieto jonaprieto added this to the 0.2 milestone May 30, 2023
@jonaprieto jonaprieto added the fix label May 30, 2023
@jonaprieto jonaprieto self-assigned this May 30, 2023
@jonaprieto jonaprieto requested a review from vrom911 May 30, 2023 17:42
Copy link
Contributor

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it fixed it for me! 🎉

@vrom911 vrom911 merged commit d8e781f into main May 31, 2023
@vrom911 vrom911 deleted the 73-documentation-button-is-now-broken branch May 31, 2023 06:17
@jonaprieto jonaprieto restored the 73-documentation-button-is-now-broken branch September 2, 2024 19:24
@jonaprieto jonaprieto deleted the 73-documentation-button-is-now-broken branch September 2, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation button is now broken
2 participants