Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec for the new Ethereum bridge smart contracts design #448

Closed
1 of 9 tasks
james-chf opened this issue Sep 6, 2022 · 3 comments
Closed
1 of 9 tasks

Spec for the new Ethereum bridge smart contracts design #448

james-chf opened this issue Sep 6, 2022 · 3 comments
Assignees
@sug0 @batconjurer
Labels
ethereum-bridge spec

Comments

@james-chf
Copy link
Contributor

james-chf commented Sep 6, 2022 •
edited
Loading

Some main changes from the previous design

  • addition of a fourth contract (vault contract) for holding escrowed ERC20s, instead of the bridge contract acting as the escrow
  • flow rate limiting for Namada -> Ethereum transfers
  • bridge contract must keep the signed root of a Merkle tree of all Namada -> Ethereum transfers

To close this issue

  • update the specs
    • transfers of power
    • upgrade process (for governance and bridge contracts)
    • update process (e.g. for bridge parameters such as the ERC20 whitelist)
    • flow rate limiting (~5% per day)
    • emergency withdrawal
    • no more proxy contract
  • make new GitHub issues for implementing changes
@james-chf james-chf self-assigned this Sep 6, 2022
@james-chf james-chf moved this to Todo in Namada-Old Sep 6, 2022
@james-chf james-chf changed the title Spec for the new Ethereum bridge smart contracts Spec for the new Ethereum bridge smart contracts design Sep 6, 2022
@james-chf james-chf mentioned this issue Sep 7, 2022
Merged
@james-chf james-chf moved this from Todo to WIP in Namada-Old Sep 8, 2022
@james-chf james-chf moved this from WIP to Pending Devnet in Namada-Old Oct 4, 2022
@james-chf james-chf moved this from Pending Devnet to Todo in Namada-Old Oct 6, 2022
@james-chf james-chf mentioned this issue Oct 20, 2022
Merged
@cwgoes
Copy link
Contributor

cwgoes commented Jan 13, 2023

@james-chf @Fraccaman what's the status of this?

@james-chf
Copy link
Contributor Author

There are still some more specs to be written to do with the Ethereum bridge

@james-chf james-chf moved this from Todo to Low-prio in Namada-Old Jan 23, 2023
@james-chf james-chf moved this from Low-prio to Todo in Namada-Old Feb 8, 2023
@james-chf james-chf removed their assignment Feb 9, 2023
@sug0
Copy link
Contributor

sug0 commented Oct 17, 2023 •
edited
Loading

see anoma/namada-docs#85

@sug0 sug0 closed this as completed Oct 17, 2023
@github-project-automation github-project-automation bot moved this from Todo to Tested in Devnet in Namada-Old Oct 17, 2023
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
@jurevans
feat/438 - Update to shortened addresses (anoma#439)
e0df6a2 
* Update private key derivation to slip10_ed25519

* Updated shared to use new addresses, fix shared tests

* Remove atest address from balance query - these are invalid

* Updated tokens to remove ERC20 for now, updated slip44 lib to get NAM

* Update commit, fix helper

* Remove Address->secret, add Address->hash

* Update to v0.26.0

* Updating for Ledger app (anoma#448)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sug0 sug0

@batconjurer batconjurer

Labels
ethereum-bridge spec
Projects
No open projects
Namada-Old
Status: Tested in Devnet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sug0 @batconjurer @cwgoes @james-chf