You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should rework the display_batch_resp function that we use to print the result of a transaction to account for a couple of things.
In case of an out-of-gas error we stille log the gas used at the batch level: this is misleading since we stop executing the tx as soon as it goes past the limit. Therefore, the resulting gas that we log is just the point where we stopped, not the actual gas required to run the transaction to completion, but logging it like this might trick users into thinking that.
We are currently not including the ResultCode of the batch in the message we display. This is useful in cases of a failing atomic batch for example, since the single inner transactions inside of it could be successful but the state changes they imply would end up being discarded
The text was updated successfully, but these errors were encountered:
We should rework the
display_batch_resp
function that we use to print the result of a transaction to account for a couple of things.ResultCode
of the batch in the message we display. This is useful in cases of a failing atomic batch for example, since the single inner transactions inside of it could be successful but the state changes they imply would end up being discardedThe text was updated successfully, but these errors were encountered: