Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better display of transactions' results #4107

Open
grarco opened this issue Nov 28, 2024 · 0 comments
Open

Better display of transactions' results #4107

grarco opened this issue Nov 28, 2024 · 0 comments
Labels

Comments

@grarco
Copy link
Contributor

grarco commented Nov 28, 2024

We should rework the display_batch_resp function that we use to print the result of a transaction to account for a couple of things.

  1. In case of an out-of-gas error we stille log the gas used at the batch level: this is misleading since we stop executing the tx as soon as it goes past the limit. Therefore, the resulting gas that we log is just the point where we stopped, not the actual gas required to run the transaction to completion, but logging it like this might trick users into thinking that.
  2. We are currently not including the ResultCode of the batch in the message we display. This is useful in cases of a failing atomic batch for example, since the single inner transactions inside of it could be successful but the state changes they imply would end up being discarded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant