Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thin wrapper for the fallback secure environment #19

Open
berendsliedrecht opened this issue Nov 22, 2024 · 2 comments
Open

Add thin wrapper for the fallback secure environment #19

berendsliedrecht opened this issue Nov 22, 2024 · 2 comments

Comments

@berendsliedrecht
Copy link
Member

Currently we just pass the fallback secure environment output to the inner functions, but it would be good to have a validation wrapper around this so we make sure the format and key type of the fallback secure environment are correct.

@TimoGlastra
Copy link
Member

I think we should not expand the fallback environment too much, it makes more sense to me that if the environment is not supported you handle it like this:

if (isLocalSecureEnvironmentSupported()) {
  // use secure environment
} else {
  // do not use this library
}

It will keep this library simpler, and there's not really that much benefit by handling it through the same interface (if someone wants to do that, they can do it still).

@TimoGlastra
Copy link
Member

We can then also remove the batch key creation, as it wouldn't make sense on other platforms. I would rather focus this library completely on the mobile secure environment APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants