Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to update to Angular 9 #51

Open
handihow opened this issue Apr 4, 2020 · 3 comments
Open

Not possible to update to Angular 9 #51

handihow opened this issue Apr 4, 2020 · 3 comments

Comments

@handihow
Copy link

handihow commented Apr 4, 2020

Bug Report or Feature Request (mark with an x)

- [ x] bug report -> please search issues before submitting
- [ ] feature request

OS and Version?

Versions

Angular 9.1

Repro steps

Update to angular 9 then run ng serve

The log given by the failure

Error: Failed to compile entry-point @angular-material-extensions/faq (module as esm5) due to compilation errors:
node_modules/@angular-material-extensions/faq/esm5/faq.es5.js:103:30 - error NG1010: Value at position 4 in the NgModule.imports of MatFaqModule is not a reference: [object Object]

103 imports: [
~
104 CommonModule,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
113 MatExpansionModule
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
114 ],
~~~~~~~~~~~~~~~~~~~~~

Error: Failed to compile entry-point @angular-material-extensions/contacts (module as esm5) due to compilation errors:
node_modules/@angular-material-extensions/contacts/esm5/contacts.es5.js:433:30 - error NG1010: Value at position 4 in the NgModule.imports of MatContactsModule is not a reference: [object Object]

433 imports: [
~
434 CommonModule,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
452 AvatarModule
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
453 ],
~~~~~~~~~~~~~~~~~~~~~

Desired functionality

would like to use this component in my app as before

Mention any other details that might be useful

https://github.com/handihow/selfiespel

@AnthonyNahas
Copy link
Member

angular v9 is not supported yet for this library!

I will upgrade this soon

@amv93
Copy link

amv93 commented May 21, 2020

Hi AnthonyNahas,
I really want to use this component in my app and I have been waiting since April 20.
Could you atleast provide an ETA? It will be really of great help for me

@odedshr
Copy link

odedshr commented Jun 4, 2020

It can be fixed by updating the imports in node_modules/@angular-material-extensions/faq/esm2015/faq.js
import { MatCardModule } from '@angular/material/card';
import { MatToolbarModule } from '@angular/material/toolbar';
import { MatButtonModule } from '@angular/material/button';
import { MatInputModule } from '@angular/material/input';
import { MatIconModule } from '@angular/material/icon';
import { MatExpansionModule } from '@angular/material/expansion';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants