Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent field naming #103

Open
typerat opened this issue Feb 29, 2024 · 1 comment
Open

Inconsistent field naming #103

typerat opened this issue Feb 29, 2024 · 1 comment

Comments

@typerat
Copy link

typerat commented Feb 29, 2024

The documentation for fetchAndJoinCustomAudience shows the field user_bidding_signals in snake case. The respective field when accessed from the bidding JS is userBiddingSignals in camel case (which took weeks to figure out, see #90).

This is specifically causing problems, as we have to use two different representations for a custom audience in our system - one for CA management and a different one for bidding - and make sure we use the correct one in each instance.

All other fields that I checked are in snake case, as expected.

@syntxerror
Copy link

Hey @typerat. We're compiling a list of the fields that need to updated as you've pointed out and will hopefully have the change put in soon to use a singular case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants