Handle new syntex for includedir statement
#10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On newer sudo versions the default inclusion statement is `@includedir` instead of `#includedir`. After running the role the directory gets included a second time: ``` @includedir /etc/sudoers.d ``` For compatibility reasons I didn't change the `line` value so on newer installations the `@includedir` will be replaced by the old syntax. Reference: > It is possible to include other sudoers files from within the --> https://www.sudo.ws/docs/man/sudoers.man/#Including_other_files_from_within_sudoers fixes andrewrothstein#9
|
@andrewrothstein We could also split this into two tasks, the first checking for the new syntax and checking for the old syntax in a second task, only if the newer syntax wasn't found. wdyt? |
|
let's do two tasks instead. keep the new fresh and support the old. |
|
Will have capacity to work on this in 2-3 weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On newer sudo versions the default inclusion statement is
@includedirinstead of#includedir. After running the role the directory gets included a second time:For compatibility reasons I didn't change the
linevalue so on newer installations the@includedirwill be replaced by the old syntax.Reference:
https://www.sudo.ws/docs/man/sudoers.man/#Including_other_files_from_within_sudoers
fixes #9