Role leads to doubled inclusion of the sudoers_dropin_dir

[fapdash]

On newer sudo versions the default inclusion statement is @includedir instead of #includedir. After running the role the directory gets included a second time:

@includedir /etc/sudoers.d
#includedir /etc/sudoers.d

This leads to annoying warnings in the terminal when aliases get defined:

/etc/sudoers.d/commands:1:382: Alias "SOMETHING_COMMANDS" already defined

Reference:

It is possible to include other sudoers files from within the sudoers file currently being parsed using the @include and @includedir directives. For compatibility with sudo versions prior to 1.9.1, #include and #includedir are also accepted.

https://www.sudo.ws/docs/man/sudoers.man/#Including_other_files_from_within_sudoers

[andrewrothstein]

I incorporated ur suggestion into v1.1.0 that I just published to the galaxy. Can take a peek and lmk if it works for u?

[fapdash]

Doesn't seem to work. :(

ansible-sudoers/tasks/main.yml

Lines 39 to 53 in b8524d5

	- name: 'ensure sudoers dropin directory is #includedir-ed'
	become: true
	become_user: root
	lineinfile:
	dest: '{{ sudoers_cfg_file }}'
	regexp: '^#includedir\s+{{ sudoers_dropin_dir }}'
	line: '#includedir {{ sudoers_dropin_dir }}'
	- name: ensure sudoers dropin directory is @includedir-ed
	become: true
	become_user: root
	lineinfile:
	dest: '{{ sudoers_cfg_file }}'
	regexp: '^@includedir\s+{{ sudoers_dropin_dir }}'
	line: '@includedir {{ sudoers_dropin_dir }}'

This still adds the #include line if @include is already defined. It now also adds the @include line, even if the #include line is already present. The include should only happen once.

I think a good way to go about that would be:

1. check if the #include line is present, don't add the line if it's not present
2. register if the #include line is present
3. check if the @include line is present, only if the #include line is missing (check via register var). add the @include line if it's missing.

But I'm not sure how to do step 1. lineinfile doesn't allow for checking if a line is present without changing the file?