Skip to content
This repository has been archived by the owner on Feb 12, 2021. It is now read-only.

Breaking errors #188

Open
jacwright opened this issue Sep 6, 2017 · 2 comments
Open

Breaking errors #188

jacwright opened this issue Sep 6, 2017 · 2 comments

Comments

@jacwright
Copy link

The graceful-fs causes a crash in node v8.2.1. The module it relies on (which is the one crashing) is natives and states in its readme:

I feel compelled to give you a word of warning if you are considering using this module.

This module lets you do some creative things with the JavaScript code in Node.js. There are some things here that are basically a recipe for memory leaks, or at the very least, being broken with each new release of Node, since none of these API surfaces are "technically" "supported" by the team managing the Node.js project.

I recommend just using the built-in fs module and removing this dependency.

@WaleedAshraf
Copy link

Yes, this is causing trouble, see here: npm/npm#19063 (comment)

Any package which is using graceful-fs<4.x is breaking in node 8.x
Kindly update to latest version or completely remove this dep.

@dguayrobotiq
Copy link

dguayrobotiq commented Nov 20, 2018

What's up with this issue? I'm getting this error using either node 8.11.3 or 10.13.0:

ERROR in ./node_modules/natives/index.js
Module not found: Error: Can't resolve 'module' in '/Users/<mydirectory>/node_modules/natives'
 @ ./node_modules/natives/index.js 2:13-30
 @ ./node_modules/s3/node_modules/graceful-fs/fs.js
 @ ./node_modules/s3/node_modules/graceful-fs/graceful-fs.js
 @ ./node_modules/s3/lib/index.js
 @ ./src/services/Daemon.ts
 @ ./src/Index.ts

ERROR in ./node_modules/natives/index.js
Module not found: Error: Can't resolve 'v8' in '/Users/<mydirectory>/node_modules/natives'
 @ ./node_modules/natives/index.js 129:4-17 152:8-21
 @ ./node_modules/s3/node_modules/graceful-fs/fs.js
 @ ./node_modules/s3/node_modules/graceful-fs/graceful-fs.js
 @ ./node_modules/s3/lib/index.js
 @ ./src/services/Daemon.ts
 @ ./src/Index.ts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants