Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (YT) Remove YouTube Stock Settings #34

Closed
4 tasks done
Francesco146 opened this issue Mar 12, 2024 · 10 comments
Closed
4 tasks done

feat: (YT) Remove YouTube Stock Settings #34

Francesco146 opened this issue Mar 12, 2024 · 10 comments

Comments

@Francesco146
Copy link
Collaborator

Application

YouTube

Feature description

Remove this stock settings from the settings page (can't do that by a toggle, i get it. but a patch during compile time as I do that with ApkTool):

  • Your data in YouTube
  • Try experimental new features
  • Purchases and memberships
  • Billing & payments
  • etc...

Screenshot_20240312_192850_ReVanced Extended
Screenshot_20240312_192853_ReVanced Extended

Motivation

Provides cleaner look to YouTube. Debloat the settings page.

Might work good along side to #28. also, might be a reasonable alternative to the extremist #22 .

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@MondayNitro
Copy link
Contributor

which xml do you edit with apktoolm to remove those settings?

@Francesco146
Copy link
Collaborator Author

which xml do you edit with apktoolm to remove those settings?

I don't remember right now, should be in resources/[lang]-values. you could grep the text you are looking for, and get the file name that way

@Aryan-Chauhan
Copy link

Bro, meaning of " extremist #22 " ?

@Francesco146
Copy link
Collaborator Author

Francesco146 commented Mar 13, 2024

Bro, meaning of " extremist #22 " ?

don't take this as an offence, but that issue is trying to get right of all settings, that contains pretty useful tabs, not considering that even ReVanced's settings their self need those to work (e.g. the autoplay one). ReVanced is not handling all of these settings, for example:

  • General
  • Background
  • Notifications
  • ...

And it's good as it is, removing them is quite 'extremist', and would remove functionality to the final product. something in between would be preferable in my opinion

@selfmusing
Copy link
Contributor

💀 That day isn't far when you guys will ask for a patch to remove YouTube from YouTube app 😭

@Francesco146
Copy link
Collaborator Author

💀 That day isn't far when you guys will ask for a patch to remove YouTube from YouTube app 😭

the ghostly [null] App :)

@Aryan-Chauhan
Copy link

Aryan-Chauhan commented Mar 13, 2024

Bro, meaning of " extremist #22 " ?

don't take this as an offence, but that issue is trying to get right of all settings, that contains pretty useful tabs, not considering that even ReVanced's settings their self need those to work (e.g. the autoplay one). ReVanced is not handling all of these settings, for example:

  • General
  • Background
  • Notifications
  • ...

And it's good as it is, removing them is quite 'extremist', and would remove functionality to the final product. something in between would be preferable in my opinion

Actually, I didn't ask for hiding all settings.

I asked for the "possibility" of hiding all of them "one-by-one". Just like "Hide Account Menu" feature where you have to type what you want to hide.

Similarly, if someone don't want to hide General, Autoplay, About, etc, then they simply won't type them in the proposed "Hide Settings Menu Components" feature.

@Francesco146
Copy link
Collaborator Author

Francesco146 commented Mar 13, 2024

I asked for the "possibility" of hiding all of them "one-by-one". Just like "Hide Account Menu" feature where you have to type what you want to hide.

my bad, that's not what I understood from your issue. just straight up think about how this patch could possibly be implemented. Then if that's what you meant, I'm agreeing with you.

Similarly, if someone don't want to hide General, Autoplay, About, etc, then they simply won't type them in the proposed "Hide Settings Menu Components" feature.

I'm fairly sure the goal you want to achieve is not possible with a Runtime patch, it should work with a compile time patch with some options in the json format.

@Aryan-Chauhan
Copy link

I asked for the "possibility" of hiding all of them "one-by-one". Just like "Hide Account Menu" feature where you have to type what you want to hide.

my bad, that's not what I understood from your issue. just straight up think about how this patch can possibly be implemented. Then if that's what you meant, I'm agreeing with you.

Similarly, if someone don't want to hide General, Autoplay, About, etc, then they simply won't type them in the proposed "Hide Settings Menu Components" feature.

I'm fairly sure the goal you want to achieve is not possible with a Runtime patch, it should work with a compile time patch with some options in the json format.

Yeah! Good point in your last line!

I have minimal coding knowledge, but even I guessed that it's not possible by some run-time modification (compile-time modification necessary).

@anddea
Copy link
Owner

anddea commented Apr 1, 2024

Added in the latest dev.

@anddea anddea closed this as completed Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants