Skip to content

Commit

Permalink
chore: switch to stdlib's slices pkg (#2148)
Browse files Browse the repository at this point in the history
* chore: switch to stdlib's slices pkg

Signed-off-by: hainenber <[email protected]>

* fix linting

Signed-off-by: Alex Goodman <[email protected]>

---------

Signed-off-by: hainenber <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Co-authored-by: Alex Goodman <[email protected]>
  • Loading branch information
hainenber and wagoodman authored Sep 20, 2023
1 parent 7d0d3e1 commit b7fa75d
Show file tree
Hide file tree
Showing 10 changed files with 13 additions and 16 deletions.
3 changes: 1 addition & 2 deletions cmd/syft/cli/options/output.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ package options

import (
"fmt"

"golang.org/x/exp/slices"
"slices"

"github.com/anchore/clio"
"github.com/anchore/syft/syft/formats"
Expand Down
1 change: 0 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ require (
github.com/wagoodman/go-progress v0.0.0-20230911172108-cf810b7e365c
github.com/xeipuuv/gojsonschema v1.2.0
github.com/zyedidia/generic v1.2.2-0.20230320175451-4410d2372cb1
golang.org/x/exp v0.0.0-20230817173708-d852ddb80c63
golang.org/x/mod v0.12.0
golang.org/x/net v0.15.0
golang.org/x/term v0.12.0 // indirect
Expand Down
2 changes: 0 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -855,8 +855,6 @@ golang.org/x/exp v0.0.0-20191227195350-da58074b4299/go.mod h1:2RIsYlXP63K8oxa1u0
golang.org/x/exp v0.0.0-20200119233911-0405dc783f0a/go.mod h1:2RIsYlXP63K8oxa1u096TMicItID8zy7Y6sNkU49FU4=
golang.org/x/exp v0.0.0-20200207192155-f17229e696bd/go.mod h1:J/WKrq2StrnmMY6+EHIKF9dgMWnmCNThgcyBT1FY9mM=
golang.org/x/exp v0.0.0-20200224162631-6cc2880d07d6/go.mod h1:3jZMyOhIsHpP37uCMkUooju7aAi5cS1Q23tOzKc+0MU=
golang.org/x/exp v0.0.0-20230817173708-d852ddb80c63 h1:m64FZMko/V45gv0bNmrNYoDEq8U5YUhetc9cBWKS1TQ=
golang.org/x/exp v0.0.0-20230817173708-d852ddb80c63/go.mod h1:0v4NqG35kSWCMzLaMeX+IQrlSnVE/bqGSyC2cz/9Le8=
golang.org/x/image v0.0.0-20190227222117-0694c2d4d067/go.mod h1:kZ7UVZpmo3dzQBMxlp+ypCbDeSB+sBbTgSJuh5dn5js=
golang.org/x/image v0.0.0-20190802002840-cff245a6509b/go.mod h1:FeLwcggjj3mMvU+oOTbSwawSJRM1uh48EjtB4UJZlP0=
golang.org/x/lint v0.0.0-20181026193005-c67002cb31c3/go.mod h1:UVdnD1Gm6xHRNCYTkRU2/jEulfH38KcIWyp/GAMgvoE=
Expand Down
2 changes: 1 addition & 1 deletion syft/formats/common/cyclonedxhelpers/format.go
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
package cyclonedxhelpers

import (
"slices"
"strings"
"time"

"github.com/CycloneDX/cyclonedx-go"
"github.com/google/uuid"
"golang.org/x/exp/slices"

"github.com/anchore/syft/internal/log"
"github.com/anchore/syft/syft/artifact"
Expand Down
9 changes: 6 additions & 3 deletions syft/formats/common/spdxhelpers/to_format_model.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@ import (
"crypto/sha1"
"fmt"
"path"
"slices"
"sort"
"strings"
"time"

"github.com/docker/distribution/reference"
"github.com/spdx/tools-golang/spdx"
"golang.org/x/exp/maps"
"golang.org/x/exp/slices"

"github.com/anchore/packageurl-go"
"github.com/anchore/syft/internal"
Expand Down Expand Up @@ -722,7 +721,11 @@ func toOtherLicenses(catalog *pkg.Collection) []*spdx.OtherLicense {

var result []*spdx.OtherLicense

ids := maps.Keys(licenses)
var ids []string
for licenseID := range licenses {
ids = append(ids, licenseID)
}

slices.Sort(ids)
for _, id := range ids {
license := licenses[id]
Expand Down
3 changes: 1 addition & 2 deletions syft/formats/formats.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@ import (
"fmt"
"io"
"regexp"
"slices"
"strings"

"golang.org/x/exp/slices"

"github.com/anchore/syft/internal/log"
"github.com/anchore/syft/syft/formats/cyclonedxjson"
"github.com/anchore/syft/syft/formats/cyclonedxxml"
Expand Down
2 changes: 1 addition & 1 deletion syft/internal/fileresolver/unindexed_directory.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ import (
"io/fs"
"os"
"path"
"slices"
"sort"
"strings"
"time"

"github.com/bmatcuk/doublestar/v4"
"github.com/mitchellh/go-homedir"
"github.com/spf13/afero"
"golang.org/x/exp/slices"

"github.com/anchore/syft/internal/log"
"github.com/anchore/syft/syft/file"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ import (
"fmt"
"io"
"log"
"slices"
"strings"

"github.com/facebookincubator/nvdtools/wfn"
"golang.org/x/exp/slices"

"github.com/anchore/syft/syft/pkg/cataloger/common/cpe/dictionary"
)
Expand Down
2 changes: 1 addition & 1 deletion syft/pkg/cataloger/package_exclusions.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package cataloger

import (
"golang.org/x/exp/slices"
"slices"

"github.com/anchore/syft/syft/artifact"
"github.com/anchore/syft/syft/pkg"
Expand Down
3 changes: 1 addition & 2 deletions syft/sbom/sbom.go
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
package sbom

import (
"slices"
"sort"

"golang.org/x/exp/slices"

"github.com/anchore/syft/internal/log"
"github.com/anchore/syft/syft/artifact"
"github.com/anchore/syft/syft/file"
Expand Down

0 comments on commit b7fa75d

Please sign in to comment.