Dev/ade9078 #2372
Open
Dev/ade9078 #2372
+2,274
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raezt
requested review from
buha,
CiprianRegus,
dbogdan,
amiclaus,
rbolboac and
danmois
as code owners
drivers/meter/ade9078/ade9078.c
Outdated
| if (!reg_data) | ||
| return -EINVAL; | ||
|
|
||
| addr = (uint16_t) no_os_field_prep(NO_OS_GENMASK(16, 4), reg_addr); |
There was a problem hiding this comment.
I think the mask should be [15:4], otherwise you'll clip bit 16 since you also cast to uint16_t.
The ADE9078 is a high performance, multiphase energy and power quality monitoring IC. This is a basic driver implementation with communication done on SPI. Signed-off-by: Radu Etz <[email protected]>
Example project for ADE9078. Tested using the ADE9078 Arduion Shield. This example includes measurements of the rms values. The example is tested with the AD-APARD32690-SL. Signed-off-by: Radu Etz <[email protected]>
|
Change log v1 -> v2:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist