Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ad9166 test #36

Open
wants to merge 1 commit into
base: libad9166-iio-v0
Choose a base branch
from
Open

Update ad9166 test #36

wants to merge 1 commit into from

Conversation

trishaange01
Copy link
Collaborator

PR Description

This change includes an update on the frequency value being set by the set_frequency() function. The fix was made due to the issue produced by the previous value, 3000000000, which is "No such device" error. Also, any value close to 3000000000 and higher causes this error. The value being set now is 2100000000.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have followed the coding standards and guidelines
  • I have conducted a self-review of my own code changes
  • I have commented new code, particulary complex or unclear areas
  • I have built libad9166-iio and check no new warnings/errors were introduced
  • I have checked that my changes did not broke components that use libad9361-iio as dependency
  • I have updated the documentation accordingly (GitHub Pages, READMEs, etc)

@trishaange01 trishaange01 requested review from SRaus and Demon000 August 1, 2024 01:05
Copy link
Contributor

@SRaus SRaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a commit description.

This change fixes the error caused by setting frequency to any value close to 3000000000 or higher
@trishaange01
Copy link
Collaborator Author

trishaange01 commented Aug 4, 2024

Please add a commit description.

Hi @SRaus. I already added a commit description and changed the commit message. :)

@trishaange01 trishaange01 requested a review from SRaus August 14, 2024 03:56
@SRaus SRaus requested a review from cristina-suteu August 21, 2024 08:19
@dNechita
Copy link

@trishaange01 are there more details about this change? Why value 3000000 is not considered a valid input?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants