User Netbox config to Validity

[rsp1991]

Hello everyone,

I'd like to user my settings (hostname, description, vlan, etc) did in Netbox to compliance, example:

device created with name SW-01, interface 0/1 with description "UPLINK"

[amyasnikov]

You may use all device properties inside test expression (e.g. device.interfaces.all() gives you access to all interfaces provisioned inside NetBox for a particular device).
Usually to compose a new test you first have to decide which properties you're going to compare with each other (e.g. compare interface descriptions inside NetBox and those ones configured on a device).

[amyasnikov]

Yep, it's a known issue of underlying library - simpleeval, I forgot about it.

There is a workaround:

dict((iface.name, iface.description) for iface in device.interfaces.all()) == \
dict((iface['interface'], iface['description']) for iface in device.state.show_running_interface['interfaces'])

[rsp1991]

Right now, I can get all config in Netbox, but from serialized it dont found one key:

I printed the list and I can see the description key:

I dont know if help, I use the code below to some check, but I use static validations (don't get it from the netbox).

not jq.all('.interfaces[] | select((.access_vlan >= "2200" and .access_vlan <= "2500") and (.device_track_max != "2" or .dhcp_snooping != "20" or .port_security_aging != "2" or .port_security_maximum != "2" or .port_security_type != "inactivity" or .port_security_violation != "restrict" or .portfast != "portfast" or .storm_action != "shutdown" or .storm_broad_max != "5.00" or .storm_broad_thre != "2.50" or .storm_mult_max != "20.00" or .storm_mult_thre != "10.00" or .switchport_mode != "access" or .description != "### WORKSTATION ###")).interface', device.state.show_running_interface)

[amyasnikov]

I suppose there is another interface inside interfaces list which has no description key. You may use iface.get('description') instead of iface['description'] to avoid the error.

And I advice you to debug your test using django shell, it helps to understand what's going on

# ./manage.py shell
>>> from validity.models import VDevice
>>> device1 = VDevice.objects.get(name='device1')
>>> print(device.config["interfaces"])

[rsp1991]

Hi,

This way worked:

dict((iface.name, iface.description) for iface in device.interfaces.all()) == \
dict((iface["interface"], iface.get('description')) for iface in device.state.show_running_interface['interfaces'])

I was testing the code, and I think that is necessary create one loop to check, because I think that the code check all, but the list is created in different order and always put false.

Do you know any some way to get the wrong interface? Throughout not jq.all that I sent, it print the wrong interfaces, this is only print true or false.

[rsp1991]

Hi,

After a lot job, the script can work well:

all([
    not jq.all(
        f'.interfaces[] | select(.interface=="{iface.name}" and .description!="{iface.description}")',
        device.state.show_running_interface
    )
    for intconf in device.state.show_running_interface['interfaces']
    for iface in device.interfaces.filter(
        name= intconf["interface"]
    )   
])