Validate OCSP response ProducedAt. #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't accept an OCSP response if its ProducedAt is outside the leaf cert's NotBefore/NotAfter validity window.
|
To make it easier to review, you may want to look at this commit separately from the vendor update. |
banaag
reviewed
Mar 26, 2021
| @@ -429,9 +429,9 @@ func (this *CertCache) readOCSP(allowRetries bool) ([]byte, time.Time, error) { | |||
|
|
|||
| // Print # of retries, wait for specified time and returned updated wait time. | |||
| func waitForSpecifiedTime(waitTimeInMinutes int, numRetries int) int { | |||
| log.Printf("Retrying OCSP server: retry #%d\n", numRetries) | |||
| log.Printf("Retrying OCSP server: retry #%d", numRetries) | |||
There was a problem hiding this comment.
Did you remove the \n on purpose? Did you mean to change it to Println then?
There was a problem hiding this comment.
Yeah, the \n is redundant. I saw this done on webpkg. It's a difference between fmt and log: https://golang.org/pkg/log/#pkg-overview:~:text=Every%20log%20message%20is%20output%20on,newline%2C%20the%20logger%20will%20add%20one.
banaag
reviewed
Mar 26, 2021
packager/certcache/certcache_test.go
Outdated
| var err error | ||
| this.fakeOCSP, err = FakeOCSPResponse(this.fakeClock.Now()) | ||
| this.fakeOCSP, err = FakeOCSPResponse(now, now.Add(1*time.Minute)) |
There was a problem hiding this comment.
Could you add a comment here as to why a minute was added?
There was a problem hiding this comment.
Good idea. Decided to extract it into the FakeOCSPResponse function so there was only one place to document it.
banaag
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't accept an OCSP response if its ProducedAt is outside the leaf cert's
NotBefore/NotAfter validity window.
Fixes #514.