Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate OCSP ProducedAt #514

Open
twifkak opened this issue Mar 25, 2021 · 1 comment
Open

Validate OCSP ProducedAt #514

twifkak opened this issue Mar 25, 2021 · 1 comment
Labels
fixit
Milestone
v3: Correctness

Comments

@twifkak
Copy link
Member

twifkak commented Mar 25, 2021

When receiving an OCSP response, AMP Packager should validate that its ProducedAt is within the NotBefore/NotAfter of the cert. I think the place to do that is here. (It looks like the ocsp.ParseResponseForCert function doesn't do this already.)
@twifkak twifkak added the fixit label Mar 25, 2021
@twifkak twifkak added this to the v3: Correctness milestone Mar 25, 2021
@twifkak
Copy link
Member Author

twifkak commented Mar 25, 2021

Filed golang/go#45244 for the upstream ocsp lib, but we should fix on our end in the meantime.

@twifkak twifkak mentioned this issue Mar 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixit
Projects
None yet
Milestone
v3: Correctness
Development

No branches or pull requests
1 participant
@twifkak