Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[owners] Add HSTS (Strict Transport Security) #585

Open
rcebulko opened this issue Oct 28, 2019 · 8 comments
Open

[owners] Add HSTS (Strict Transport Security) #585

rcebulko opened this issue Oct 28, 2019 · 8 comments

Comments

@rcebulko
Copy link
Contributor

No description provided.

@kristoferbaxter
Copy link

Since this is hosted by App Engine, here's the relevant segment from AppEngine's faq.

It is possible to use Strict-Transport-Security in App Engine. In order to add HTTP Strict-Transport-Security headers (HSTS) to your app, you must implement the headers within your app's code, not within your app's config file (app.yaml or appengine-web.xml).

https://cloud.google.com/appengine/kb/

@rcebulko
Copy link
Contributor Author

Unclear how necessary this is at the time being, since there is no authentication/it's public-facing and GitHub authenticates with PSK

@rcebulko
Copy link
Contributor Author

@ampproject/wg-infra Do any of our apps use HSTS? Is there a need? I'm inclined to say there is not given the nature of the apps, but perhaps I'm missing something

@danielrozenberg
Copy link
Member

It's a good extra step, regardless of how "important" the apps are, but don't overthink it. Unless it's a simple flag in GAE config, make this a fixit week task and forget about it until next year :)

@rcebulko
Copy link
Contributor Author

That was my thought

@danielrozenberg
Copy link
Member

Still relevant, let's do it next fixit

@rcebulko
Copy link
Contributor Author

Is this relevant? There's no sensitive data present in any of the browser-accessible endpoints for the owners bot. It's just the teams, tree, and example file. What threat model would this address?

@danielrozenberg
Copy link
Member

It's one extra layer of security, it's definitely not required but it does tell the world we're Professionals :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants