Raise error when no files found to pass to standard #7
Conversation
|
I hadn't realized there was an "official" standard action until spending some time on this today. So I am happy to have this (and the other PRs) merged if you find them useful. I was going to submit a PR to switch this action from a docker-based one to a "composite" action, but there are some improvements in the official repo that I think make it a better choice moving forward, so I've submitted that PR there instead. Thanks for publishing this action in the first place, it has been useful! |
|
Thanks @taylorthurlow. You're right that there's an official action so changes are better off over there. I'm going to update the README for this repo and mark it archived so it's clear. |
|
Hey @taylorthurlow, I just checked and it's unclear to me if https://github.com/standardrb/standard-ruby-action is actually maintained any longer so if you have any trouble getting PRs merged over there please feel free to come back here and re-open your PRs. |
|
Will do - in this case I think the lack of activity is probably more due to the lack of need for changes, but I'll definitely follow up here again if all else fails. Appreciate your time 😄 |
|
If you end up getting your PRs merged, you might see if they'll publish the action to the marketplace (it's currently not listed), unpublish or update https://github.com/marketplace/actions/standardrb-action and archive https://github.com/andrewmcodes/standardrb-action. |
|
Opened standardrb/standard-ruby-action#8 👍 |
In setting up this action I had misconfigured things, and it took me a while to realize that my builds were "passing" not because they were free of errors, but standardrb was exiting successfully because it processed zero files. I think it's a fair assumption that something is wrong if no files are reported as checked by standardrb, so this just raises an error in that case rather than silently working.