From f44d9e82d2c1ff4348f0ddd8ae32597f3bccf057 Mon Sep 17 00:00:00 2001 From: Liquan Pei Date: Mon, 15 Apr 2024 14:46:02 -0700 Subject: [PATCH] [BUG] Make the gracefulperiod to be 0 for pod deletion (#2011) ## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Make the gracefulperiod to be 0 for pod deletion - New functionality - ... ## Test plan *How are these changes tested?* - [ ] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?* --- go/pkg/memberlist_manager/memberlist_manager_test.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/go/pkg/memberlist_manager/memberlist_manager_test.go b/go/pkg/memberlist_manager/memberlist_manager_test.go index 343ec3d9f2e..cbe6d011e43 100644 --- a/go/pkg/memberlist_manager/memberlist_manager_test.go +++ b/go/pkg/memberlist_manager/memberlist_manager_test.go @@ -132,7 +132,10 @@ func createFakePod(ip string, clientset kubernetes.Interface) { } func deleteFakePod(ip string, clientset kubernetes.Interface) { - clientset.CoreV1().Pods("chroma").Delete(context.TODO(), ip, metav1.DeleteOptions{}) + gracefulPeriodSeconds := int64(0) + clientset.CoreV1().Pods("chroma").Delete(context.TODO(), ip, metav1.DeleteOptions{ + GracePeriodSeconds: &gracefulPeriodSeconds, + }) } func TestMemberlistManager(t *testing.T) {