Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in llm_checker's is_joint code path #27

Open
rchaks opened this issue Nov 11, 2024 · 0 comments
Open

Possible bug in llm_checker's is_joint code path #27

rchaks opened this issue Nov 11, 2024 · 0 comments

Comments

@rchaks
Copy link

rchaks commented Nov 11, 2024

In the is_joint code path, the prompt template seems to be hard-coded to the JOINT_CHECKING_PROMPT_Q prompt that requires a question to be passed in:

prompt_template = JOINT_CHECKING_PROMPT_Q
.

However, I think this should be using self.prompt_temp or self.prompt_temp_wq depending on whether question is None just like the non joint checker:

if question is None:
?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant