Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support SProd and CompositeOp for expval #275

Merged
merged 6 commits into from
Sep 6, 2024
Merged

feat: Support SProd and CompositeOp for expval #275

merged 6 commits into from
Sep 6, 2024

Conversation

speller26
Copy link
Member

Issue #, if available:
#253
Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@speller26 speller26 requested a review from a team as a code owner September 6, 2024 02:27
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b154dce) to head (15012c2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #275   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         1242      1244    +2     
  Branches       305       302    -3     
=========================================
+ Hits          1242      1244    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@speller26
Copy link
Member Author

@astralcai Feel free to check if this implementation makes sense.

@astralcai
Copy link
Contributor

Since it's passing PL integration tests I say it's good.

@speller26 speller26 changed the title feat: Support SProd and Sum for expval feat: Support SProd and CompositeOp for expval Sep 6, 2024
@speller26 speller26 merged commit df838cb into main Sep 6, 2024
20 checks passed
@speller26 speller26 deleted the sprod branch September 6, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants