Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: add PL device testing using a stable PL version #264

Merged
merged 12 commits into from
Sep 5, 2024
Merged

Conversation

AbeCoull
Copy link
Contributor

@AbeCoull AbeCoull commented May 31, 2024

Issue #, if available:

Description of changes:
Tests the latest Braket code against the latest release of PennyLane. Includes a tox env for better local testing.

Testing done:
tox -e pennylane-device-tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (043a332) to head (67cb7c6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #264   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         1242      1242           
  Branches       305       305           
=========================================
  Hits          1242      1242           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AbeCoull AbeCoull marked this pull request as ready for review June 2, 2024 17:51
@AbeCoull AbeCoull requested a review from a team as a code owner June 2, 2024 17:51
Copy link
Member

@speller26 speller26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should this be infra; it adds a workflow, and the only change to setup.py is in extras_require["test"]

.github/workflows/braket-latest-pl-stable.yml Outdated Show resolved Hide resolved
@AbeCoull AbeCoull changed the title feat: add PL device testing using a stable PL version infra: add PL device testing using a stable PL version Jun 2, 2024
@AbeCoull
Copy link
Contributor Author

AbeCoull commented Jun 3, 2024

Build is expected to fail until #253 is resolved

Copy link
Member

@speller26 speller26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to add this as a tox target so we can run the device tests locally?

@AbeCoull
Copy link
Contributor Author

AbeCoull commented Jun 7, 2024

Is there a way to add this as a tox target so we can run the device tests locally?

@speller26, added tox -e pennylane-device-tests

@speller26 speller26 merged commit b154dce into main Sep 5, 2024
17 of 20 checks passed
@speller26 speller26 deleted the pl_testing branch September 5, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants