-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix importlib DeprecationWarning; Removes expected test message to account for changes in Python3.11 #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsheni
reviewed
Dec 2, 2022
Codecov Report
@@ Coverage Diff @@
## main #1584 +/- ##
==========================================
- Coverage 98.94% 98.94% -0.01%
==========================================
Files 93 93
Lines 11186 11184 -2
==========================================
- Hits 11068 11066 -2
Misses 118 118
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I think the codecov issues should resolve as soon as we start testing with 3.11. |
sbadithe
changed the title
Fix importlib DeprecationWarning
Fix importlib DeprecationWarning; Adjust test message for Python3.11
Dec 5, 2022
sbadithe
changed the title
Fix importlib DeprecationWarning; Adjust test message for Python3.11
Fix importlib DeprecationWarning; Adjust expected test message to account for changes in Python3.11
Dec 5, 2022
sbadithe
commented
Dec 6, 2022
sbadithe
commented
Dec 6, 2022
ozzieD
reviewed
Dec 6, 2022
ozzieD
reviewed
Dec 6, 2022
ozzieD
approved these changes
Dec 6, 2022
sbadithe
changed the title
Fix importlib DeprecationWarning; Adjust expected test message to account for changes in Python3.11
Fix importlib DeprecationWarning; Removes expected test message to account for changes in Python3.11
Dec 6, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
woodwork[dask]
pass with python 3.11