Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importlib DeprecationWarning; Removes expected test message to account for changes in Python3.11 #1584

Merged
merged 19 commits into from
Dec 6, 2022

Conversation

sbadithe
Copy link
Contributor

@sbadithe sbadithe commented Nov 22, 2022

pyproject.toml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #1584 (15d5084) into main (ecaff84) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1584      +/-   ##
==========================================
- Coverage   98.94%   98.94%   -0.01%     
==========================================
  Files          93       93              
  Lines       11186    11184       -2     
==========================================
- Hits        11068    11066       -2     
  Misses        118      118              
Impacted Files Coverage Δ
woodwork/tests/accessor/test_statistics.py 100.00% <100.00%> (ø)
woodwork/tests/accessor/test_table_accessor.py 100.00% <100.00%> (ø)
woodwork/tests/fixtures/datetime_freq.py 100.00% <100.00%> (ø)
woodwork/type_sys/inference_functions.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sbadithe
Copy link
Contributor Author

sbadithe commented Dec 3, 2022

I think the codecov issues should resolve as soon as we start testing with 3.11.

@sbadithe sbadithe changed the title Fix importlib DeprecationWarning Fix importlib DeprecationWarning; Adjust test message for Python3.11 Dec 5, 2022
@sbadithe sbadithe marked this pull request as ready for review December 5, 2022 18:52
@sbadithe sbadithe changed the title Fix importlib DeprecationWarning; Adjust test message for Python3.11 Fix importlib DeprecationWarning; Adjust expected test message to account for changes in Python3.11 Dec 5, 2022
pyproject.toml Show resolved Hide resolved
woodwork/tests/accessor/test_table_accessor.py Outdated Show resolved Hide resolved
woodwork/tests/fixtures/datetime_freq.py Outdated Show resolved Hide resolved
woodwork/tests/accessor/test_statistics.py Show resolved Hide resolved
@sbadithe sbadithe changed the title Fix importlib DeprecationWarning; Adjust expected test message to account for changes in Python3.11 Fix importlib DeprecationWarning; Removes expected test message to account for changes in Python3.11 Dec 6, 2022
@sbadithe sbadithe merged commit 70652b9 into main Dec 6, 2022
@sbadithe sbadithe deleted the fix-open-text-deprecation branch December 6, 2022 20:56
@bchen1116 bchen1116 mentioned this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecatingWarning from using open_text in Natural Language inference function
5 participants