New feature and elisp rewrite

[andruska]

Added new propery org-sticky-header-clean-face.
org-sticky-header--heading-string rewrite for this new property. Elisp code upgrade to pcase and pcase-let*.

[alphapapa]

1. Please describe the purpose of these changes.
2. Although I use pcase extensively, it's not necessary to change working code. Please limit your changes to those which are necessary to implement the fixes or additions you're proposing.

[andruska]

They were part of the TODO keywords in the source code.

org-sticky-header/org-sticky-header.el

Lines 187 to 188 in 6978759

	;; TODO: Update minimum Emacs version and use `pcase-let*'.
	(let* ((components (org-heading-components))

Purpose
#25 (comment)

[alphapapa]

They were part of the TODO keywords in the source code.

org-sticky-header/org-sticky-header.el

Lines 187 to 188 in 6978759

	;; TODO: Update minimum Emacs version and use `pcase-let*'.
	(let* ((components (org-heading-components))

Indeed, but those changes aren't related to the purpose of this one, so making the change in the same pull request makes the code much more work to review. If that change were to be made, it should be done separately.

Purpose #25 (comment)

Ok, but that issue was from over 3.5 months ago, so I need you to link me to it if you want me to know about it.

Regarding the other changes made: Why is face-foreground being used? Can you show me before/after screenshots to help me understand why this is needed and what the end result looks like?

[andruska]

• Current org-sticky-header master branch

• Pull request w/ org-sticky-header-clean-face nil

• Pull request w/ org-sticky-header-clean-face t

[alphapapa]

Thanks for the screenshots. Here are the next steps that need to be taken:

• Remove changes that aren't related to the face issue. (While I appreciate your wanting to help there, those extra lines of changes make it harder to distinguish the ones related to the face issue.)
• Clearly define what this option is intended to do. (i.e. I don't know how to explain what "clean face" means or does)
• Update the new option's docstring accordingly, and maybe rename it.
• Test the changes to make sure they work correctly (e.g. in combination with other options, themes, etc).

Then this PR could be merged.

[andruska]

I have been using this code snippet for 3.5 months now, it solved my original problem and it acts better on different themes. My goal was to share this little fix. If there is interest, it can be merged.