From 8ee0afebea1d18bb0cdd743968401b5323166723 Mon Sep 17 00:00:00 2001
From: Sean Rankine <sean.rankine@me.com>
Date: Wed, 4 Sep 2024 11:16:30 +0100
Subject: [PATCH] Remove support for temporary redirects

These redirects are 302 Found responses, however no longer used.
Removing to simplify the codebase.
---
 app/controllers/routes_controller.rb | 2 ++
 app/models/route.rb                  | 4 +---
 lib/tasks/redirect.rake              | 1 -
 spec/factories/routes.rb             | 1 -
 spec/models/route_spec.rb            | 1 -
 5 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/app/controllers/routes_controller.rb b/app/controllers/routes_controller.rb
index 912ae1dc..0f593cb9 100644
--- a/app/controllers/routes_controller.rb
+++ b/app/controllers/routes_controller.rb
@@ -10,6 +10,8 @@ def show
   def update
     route_details = @request_data[:route]
     incoming_path = route_details.delete(:incoming_path)
+    # TODO: remove this once gds-api-adapters no longer send this attribute
+    route_details.delete("redirect_type")
     tries = 3
     begin
       @route = Route.find_or_initialize_by(incoming_path:)
diff --git a/app/models/route.rb b/app/models/route.rb
index 1c292b4d..5854efb7 100644
--- a/app/models/route.rb
+++ b/app/models/route.rb
@@ -7,7 +7,6 @@ class Route
   field :handler, type: String
   field :backend_id, type: String
   field :redirect_to, type: String
-  field :redirect_type, type: String
   field :segments_mode, type: String
 
   index({ incoming_path: 1 }, unique: true)
@@ -30,7 +29,6 @@ class Route
   with_options if: :redirect? do
     validates :redirect_to, presence: true
     validate :validate_redirect_to
-    validates :redirect_type, inclusion: { in: %w[permanent temporary] }
     validates :segments_mode, inclusion: { in: %w[ignore preserve] }
   end
 
@@ -61,7 +59,7 @@ def soft_delete
     if has_parent_prefix_routes?
       destroy!
     else
-      update!(handler: "gone", backend_id: nil, redirect_to: nil, redirect_type: nil)
+      update!(handler: "gone", backend_id: nil, redirect_to: nil)
     end
   end
 
diff --git a/lib/tasks/redirect.rake b/lib/tasks/redirect.rake
index 879cff1d..b3917a57 100644
--- a/lib/tasks/redirect.rake
+++ b/lib/tasks/redirect.rake
@@ -12,7 +12,6 @@ def redirect(old_path, new_path)
     route_type: "exact",
     handler: "redirect",
     backend_id: "whitehall-frontend",
-    redirect_type: "permanent",
     segments_mode: "ignore",
   )
 end
diff --git a/spec/factories/routes.rb b/spec/factories/routes.rb
index e835d003..69a5cda3 100644
--- a/spec/factories/routes.rb
+++ b/spec/factories/routes.rb
@@ -14,7 +14,6 @@
     factory :redirect_route do
       handler { "redirect" }
       redirect_to { "/bar" }
-      redirect_type { "permanent" }
     end
 
     factory :gone_route do
diff --git a/spec/models/route_spec.rb b/spec/models/route_spec.rb
index 1ab81c98..1fca67fa 100644
--- a/spec/models/route_spec.rb
+++ b/spec/models/route_spec.rb
@@ -261,7 +261,6 @@
       route.update!(
         handler: "redirect",
         redirect_to: "/",
-        redirect_type: "permanent",
       )
       route.reload