-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Str 106 csm test util #514
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- at horizon block - at horizon + 1 - at genesis but not locked
- Used table approach where a single runner consolidates all code execution logic, eliminating repetition of code. - Exception: test_l1_reorg behaves quite differently so left as a special case
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #514 +/- ##
==========================================
+ Coverage 56.45% 58.53% +2.07%
==========================================
Files 273 277 +4
Lines 29079 29328 +249
==========================================
+ Hits 16416 17166 +750
+ Misses 12663 12162 -501
|
delbonis
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor cleanups.
bewakes
reviewed
Dec 3, 2024
bewakes
reviewed
Dec 3, 2024
- changed Vec to [] - added l1_reorg test
bewakes
reviewed
Dec 4, 2024
delbonis
approved these changes
Dec 4, 2024
bewakes
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Consolidates repeated testing logic to a single function.
Type of Change
Notes to Reviewers
Please suggest on handling test_l1_reorg(). Do we not apply writes for this particular case?
Checklist
Related Issues
STR-106