Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Str 106 csm test util #514

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Str 106 csm test util #514

merged 3 commits into from
Dec 5, 2024

Conversation

purusang
Copy link
Contributor

@purusang purusang commented Dec 2, 2024

Description

Consolidates repeated testing logic to a single function.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Please suggest on handling test_l1_reorg(). Do we not apply writes for this particular case?

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

STR-106

- at horizon block
- at horizon + 1
- at genesis but not locked
- Used table approach where a single runner consolidates all code execution logic,
eliminating repetition of code.
- Exception: test_l1_reorg behaves quite differently so left as a special case
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 98.16514% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.53%. Comparing base (0ea3c38) to head (8be3149).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
...rates/consensus-logic/src/csm/client_transition.rs 98.16% 4 Missing ⚠️
@@            Coverage Diff             @@
##             main     #514      +/-   ##
==========================================
+ Coverage   56.45%   58.53%   +2.07%     
==========================================
  Files         273      277       +4     
  Lines       29079    29328     +249     
==========================================
+ Hits        16416    17166     +750     
+ Misses      12663    12162     -501     
Files with missing lines Coverage Δ
...rates/consensus-logic/src/csm/client_transition.rs 64.40% <98.16%> (+2.38%) ⬆️

... and 71 files with indirect coverage changes

Copy link
Contributor

@delbonis delbonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor cleanups.

crates/consensus-logic/src/csm/client_transition.rs Outdated Show resolved Hide resolved
crates/consensus-logic/src/csm/client_transition.rs Outdated Show resolved Hide resolved
crates/consensus-logic/src/csm/client_transition.rs Outdated Show resolved Hide resolved
crates/consensus-logic/src/csm/client_transition.rs Outdated Show resolved Hide resolved
@purusang purusang self-assigned this Dec 4, 2024
- changed Vec to []
- added l1_reorg test
@purusang purusang requested review from delbonis and bewakes December 4, 2024 04:54
@purusang purusang marked this pull request as ready for review December 5, 2024 04:43
@purusang purusang requested a review from a team as a code owner December 5, 2024 04:43
@purusang purusang added this pull request to the merge queue Dec 5, 2024
@purusang purusang requested a review from bewakes December 5, 2024 04:43
Merged via the queue into main with commit 7425015 Dec 5, 2024
17 checks passed
@purusang purusang deleted the STR-106-csm-test-util branch December 5, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants