-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ProofReceipt
struct
#510
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #510 +/- ##
==========================================
- Coverage 58.45% 58.44% -0.02%
==========================================
Files 278 278
Lines 29290 29303 +13
==========================================
+ Hits 17122 17126 +4
- Misses 12168 12177 +9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work with the docstrings. I think this is an overall good idea. Just have 1 thing to discuss.
a695f66
to
9b51c64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 38d3e01
I had a nit with the pub
fields in ProofReceipt
that making them not pub
is more future-proof.
Description
The current
Proof
type inzkvm/src/proof
is overloaded, sometimes including public values and sometimes not. This PR tries to address this ambiguity needs by creatingProofReceipt
struct .Type of Change
Notes to Reviewers
Checklist
Related Issues