Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STR-182 chainstate manager refactors #466

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

delbonis
Copy link
Contributor

Description

This sets up the chainstate interface, to do more of the bookkeeping in memory and avoid hitting the database as much.

Somewhat blocked on refactoring the traits, as I just realized halfway through making this. On hold for a bit as that should be merged soon.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

@delbonis delbonis changed the title STR-182 STR-182 chainstate manager refactors Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 57.22%. Comparing base (d8b1013) to head (7d0a99c).

Files with missing lines Patch % Lines
crates/storage/src/ops/chainstate.rs 0.00% 32 Missing ⚠️
@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
- Coverage   57.30%   57.22%   -0.08%     
==========================================
  Files         252      253       +1     
  Lines       28207    28239      +32     
==========================================
- Hits        16165    16161       -4     
- Misses      12042    12078      +36     
Files with missing lines Coverage Δ
crates/storage/src/ops/chainstate.rs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant