Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sunburst arc ordering deterministic #67

Open
allenday opened this issue Feb 17, 2019 · 3 comments
Open

make sunburst arc ordering deterministic #67

allenday opened this issue Feb 17, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers tracked

Comments

@allenday
Copy link
Owner

currently when it refreshes the segments can move around.
I suggest ordering by either:

  • lexicographic on segment name
  • proportional size of segment
@allenday allenday added enhancement New feature or request good first issue Good for newcomers labels Feb 17, 2019
@allenday
Copy link
Owner Author

@Firedrops want to take this one?

@Firedrops
Copy link
Contributor

Firedrops commented Feb 18, 2019

Same as other visualizer issue, it seems other examples use code like this to render the arcs, which also orders them.

var arc = d3.svg.arc()
    .startAngle(function(d) { return Math.max(0, Math.min(2 * Math.PI, x(d.x))); })
    .endAngle(function(d) { return Math.max(0, Math.min(2 * Math.PI, x(d.x + d.dx))); })
    .innerRadius(function(d) { return Math.max(0, y(d.y)); })
    .outerRadius(function(d) { return Math.max(0, y(d.y + d.dy)); });

but I can't find anything superficially similar in our source. Might be able to spot it with some learning, though.

@allenday
Copy link
Owner Author

allenday commented Feb 18, 2019 via email

@obsh obsh added the tracked label Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers tracked
Projects
None yet
Development

No branches or pull requests

3 participants