Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resetKeyFromEntry #350

Open
SNGxx opened this issue Jan 3, 2023 · 1 comment
Open

resetKeyFromEntry #350

SNGxx opened this issue Jan 3, 2023 · 1 comment
Labels
bug

Comments

@SNGxx
Copy link

SNGxx commented Jan 3, 2023 

func resetKeyFromEntry(data []byte) {
	binary.LittleEndian.PutUint64(data[timestampSizeInBytes:], 0)
}

this function reset the hashed key to zero, while the function name is "resetKeyFromEntry".
i think "resetHashFromEntry" is better.
@SNGxx SNGxx added the bug label Jan 3, 2023
@janisz
Copy link
Collaborator

janisz commented Jan 3, 2023

Sounds reasonable, waiting for a PR :)

@yangtaoran yangtaoran mentioned this issue May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janisz @SNGxx